Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] resource reservation does not consider scale up via cluster-autoscaler #2113

Open
lukasmrtvy opened this issue Jun 19, 2024 · 7 comments
Labels
area/koord-scheduler kind/question Support request or question relating to Koordinator
Milestone

Comments

@lukasmrtvy
Copy link

Hi, I don't understand correctly the reservation concept. There is an alternative mentioned in docs ( https://koordinator.sh/docs/designs/resource-reservation ) with balloon/pause pods, but these are triggering the scale-up event, thus it's possible to overprovision the cluster. Reservation does not work like this. I would like to have additional reservation for ad-hoc pods ( lets say to have two "spare" nodes to cover some peaks ). Is it possible? Thanks

@lukasmrtvy lukasmrtvy added the kind/question Support request or question relating to Koordinator label Jun 19, 2024
@saintube
Copy link
Member

@lukasmrtvy Hi, the reservation would not trigger the scale-up while the vanilla version of the cluster autoscaler is not aware of the reservation's scheduling result. For this purpose, we need to develop the CA to cooperate with the current version of the reservation. It is a good point for us to support cluster overprovision with the vanilla CA.
However, the reservation can reserve the allocatable resources such that other unmatched pods cannot preempt them, which frees us from allocating the reserved resources by the preemption.
/cc @ZiMengSheng

@lukasmrtvy
Copy link
Author

Kueue has implemented https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/proposals/provisioning-request.md, could it be perhaps similar for Koordinator ?

@saintube
Copy link
Member

Kueue has implemented https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/proposals/provisioning-request.md, could it be perhaps similar for Koordinator ?

@lukasmrtvy Yes, they are similar in reserving resources for owner pods. I appreciate your reminder. We are interested in this protocol and maybe we can resolve the above problem with this.

@lukasmrtvy
Copy link
Author

@saintube Thanks. The lack of support for CA is the main problem preventing me from adopting Koordinator, so if it is going to be implemented anytime soon, then it would be superb.

@saintube saintube added this to the someday milestone Jul 17, 2024
@JBinin
Copy link
Contributor

JBinin commented Sep 10, 2024

Kindly to ask if there is somebody working for this issue? If not, I'm glad to undertake it. @saintube

@saintube
Copy link
Member

Kindly to ask if there is somebody working for this issue? If not, I'm glad to undertake it. @saintube

@JBinin Yes. Welcome to contribute!

@lukasmrtvy
Copy link
Author

any update here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/koord-scheduler kind/question Support request or question relating to Koordinator
Projects
None yet
Development

No branches or pull requests

3 participants