Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Godot 3 #1

Open
padreputativo opened this issue Aug 23, 2021 · 5 comments · May be fixed by #2
Open

Update to Godot 3 #1

padreputativo opened this issue Aug 23, 2021 · 5 comments · May be fixed by #2
Assignees

Comments

@padreputativo
Copy link

Can you update it to Godot 3?

@kondelik
Copy link
Owner

I can look at it, but currently I dont have any spare time...

It should not be hard - there is new ViewportContainer managing size of viewport + there would be some changes in shader (like adding const to, well, const 😄 )

AFAIK nothing groundbreaking.

(btw I am owner of this repo - but I changed my github handler because we start using github at work and I didnt use email in git client, so every public repo i commited into is now linked to some random guy who take my old handler 😩 )

@kondelik kondelik self-assigned this Aug 31, 2021
@kondelik kondelik linked a pull request Aug 31, 2021 that will close this issue
@kondelik
Copy link
Owner

kondelik commented Aug 31, 2021

If you want this shader in Godot 3x see PR #2 (WIP, missing Readme.md and some polishing - but you can just clone branch godot3x and give it a try.

Usage is pretty much the same as was for godot2x.

Have whole game under own Viewport and give material to ViewportContainer + maybe have gui in different layer (so it would not be grained)

@padreputativo
Copy link
Author

Many thanks!

@kondelik
Copy link
Owner

kondelik commented Sep 6, 2021

Please, dont close issues with Pull Request - accepting PR will close linked issues 😉 And because #2 is still Work In Progress (i dont have time for polishing), this issue should remains open 😅

@kondelik kondelik reopened this Sep 6, 2021
@padreputativo
Copy link
Author

Ops Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants