Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check recovery actions before editing them #1852

Closed
RebeccaMahany opened this issue Sep 9, 2024 · 0 comments · Fixed by #1859
Closed

Check recovery actions before editing them #1852

RebeccaMahany opened this issue Sep 9, 2024 · 0 comments · Fixed by #1859

Comments

@RebeccaMahany
Copy link
Contributor

On launcher service startup on Windows, we check the registry for settings related to running the launcher service, and edit those settings as needed, to ensure a consistent service definition across earlier and more recent launcher installations.

One of the settings we edit is recovery actions. Unlike with our other edits, we don't read the current state of those settings before setting them. We should update this function to read the current settings first, and only perform an edit if they aren't already set correctly, in order to reduce the number of times we edit the registry.

The relevant function lives here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant