Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kolide flags sk SSH key handles as unencrypted private keys #1768

Closed
smlx opened this issue Jul 3, 2024 · 4 comments
Closed

Kolide flags sk SSH key handles as unencrypted private keys #1768

smlx opened this issue Jul 3, 2024 · 4 comments

Comments

@smlx
Copy link

smlx commented Jul 3, 2024

SSH sk key handles (FIDO2 token backed) stored on disk are incorrectly flagged as unencrypted private keys.

These files are unencrypted but they just contain a handle to the private key which is stored on the FIDO2 token. So kolide should not flag these as a problem.

@smlx smlx changed the title Kolide incorrectly flags sk SSH keys as unencrypted Kolide incorrectly flags sk SSH key handles as unencrypted private keys Jul 3, 2024
@smlx smlx changed the title Kolide incorrectly flags sk SSH key handles as unencrypted private keys Kolide flags sk SSH key handles as unencrypted private keys Jul 3, 2024
@directionless
Copy link
Contributor

Probably a dup of #758

@directionless
Copy link
Contributor

@smlx I don't use FIDO2 keys. Can you provide us with some sample keys? (or are they confidential)

@smlx
Copy link
Author

smlx commented Jul 4, 2024

Hmm. Thinking about this some more, key handles may still be considered sensitive even though they don't contain a plaintext private key.

I'll close this issue, sorry for the noise.

@smlx smlx closed this as completed Jul 4, 2024
@directionless
Copy link
Contributor

I'm starting to dig into this.

Tinkering with a yubikey, and using it to create some resident keys, it still gives me the option to encrypt them. So I think there are four possible states: [disk|hardware] [encrypted|unencrypted]

I don't know how common it is to encrypt keys stored in hardware, but I think I would not want to misrepresent that. As is, this table appears to correctly convey that state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants