Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes launcher on Windows cannot find a valid osquery executable #1503

Closed
1 of 2 tasks
RebeccaMahany opened this issue Dec 11, 2023 · 1 comment
Closed
1 of 2 tasks

Comments

@RebeccaMahany
Copy link
Contributor

RebeccaMahany commented Dec 11, 2023

We see logs on osquery extension startup showing:

  1. no osquery updates found
  2. the originally installed osquery executable is determined to not be executable: fullBinaryPath not executable. Returning nil
  3. launcher attempts to start up osquery with an empty string for the osqueryd path, which does not work

The simplest explanation could be that the timeout is just too short on Windows sometimes (maybe/especially when the system is in modern standby?).

To address this issue:

  • We should log the CheckExecutable error in this case, to diagnose why launcher is having this issue: Fully log CheckExecutable failures #1504
  • Depending on the results, we should address the issue -- maybe adjusting the timeout for the executable check, or adjusting the check in some other way, or adjusting the osquery extension startup behavior to not require the executable check or to fall back to running the originally-installed osquery executable regardless of check status.
@RebeccaMahany
Copy link
Contributor Author

Addressed by #1788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant