From 47f01358afc64091d1a9a284b4166f5b32514a40 Mon Sep 17 00:00:00 2001 From: Anatoly Kupriyanov Date: Fri, 30 Aug 2019 18:49:12 +0100 Subject: [PATCH] Accept success codes only while uploading to http Following redirects is not safe solution, see https://stackoverflow.com/questions/1884230/urlconnection-doesnt-follow-redirect https://github.com/kiwigrid/helm-maven-plugin/issues/52 --- src/main/java/com/kiwigrid/helm/maven/plugin/UploadMojo.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/kiwigrid/helm/maven/plugin/UploadMojo.java b/src/main/java/com/kiwigrid/helm/maven/plugin/UploadMojo.java index 0d028581..fdd9ec07 100644 --- a/src/main/java/com/kiwigrid/helm/maven/plugin/UploadMojo.java +++ b/src/main/java/com/kiwigrid/helm/maven/plugin/UploadMojo.java @@ -73,7 +73,7 @@ private void uploadSingle(String file) throws IOException, BadUploadException, M try (FileInputStream fileInputStream = new FileInputStream(fileToUpload)) { IOUtils.copy(fileInputStream, connection.getOutputStream()); } - if (connection.getResponseCode() >= 400) { + if (connection.getResponseCode() >= 300) { String response = IOUtils.toString(connection.getErrorStream(), Charset.defaultCharset()); throw new BadUploadException(response); } else {