Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: allow non-squash merges #42

Open
tylerjereddy opened this issue Aug 23, 2022 · 0 comments
Open

DEV: allow non-squash merges #42

tylerjereddy opened this issue Aug 23, 2022 · 0 comments

Comments

@tylerjereddy
Copy link
Contributor

Looks like the repo doesn't allow individual commits in a PR branch to be preserved on merging (see below). The debate around this stuff isn't super interesting, but I'd argue that leaving the decision about whether individual commits in a branch merit preservation is best left to the reviewer/merger, rather than having a hard-block at the repo level. Sometimes individual commits are complex and have well-written commit messages, and could be productively revisited later on, etc.

image

Also, pykokkos repo doesn't have this restriction, FWIW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant