Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numberOfTeams in TeamPolicy related slides #23

Open
SteffenSeckler opened this issue Oct 24, 2019 · 0 comments
Open

numberOfTeams in TeamPolicy related slides #23

SteffenSeckler opened this issue Oct 24, 2019 · 0 comments

Comments

@SteffenSeckler
Copy link

In the slides to the current tutorials (e.g., https://github.com/kokkos/kokkos-tutorials/blob/master/Intro-Full/Slides/KokkosTutorial_PACT19.pdf, p. 101ff)
the constructor to TeamPolicy is described as:

TeamPolicy < ExecutionSpace >( numberOfTeams , teamSize )

while on the official kokkos wiki the constructor looks like the following (https://github.com/kokkos/kokkos/wiki/Kokkos::TeamPolicy):

Kokkos::TeamPolicy<>( league_size, team_size [, vector_length])

In my opinion the name numberOfTeams is very misleading, as it appears to be dependent on the teamSize, which it is not. It should be renamed to league_size.

The calculation of work on page 101 might also need an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant