Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOKKOS_CUSPARSE_SAFE_CALL has KOKKOS_ prefix #2371

Open
cwpearson opened this issue Oct 10, 2024 · 2 comments
Open

KOKKOS_CUSPARSE_SAFE_CALL has KOKKOS_ prefix #2371

cwpearson opened this issue Oct 10, 2024 · 2 comments

Comments

@cwpearson
Copy link
Contributor

// The macro below defines is the public interface for the safe cusparse calls.
// The functions themselves are protected by impl namespace.
#define KOKKOS_CUSPARSE_SAFE_CALL(call) KokkosSparse::Impl::cusparse_internal_safe_call(call, #call, __FILE__, __LINE__)

Let's be good ecosystem partners and prefix this with KOKKOSSPARSE_ instead.

I personally don't think this should be part of our interface. Is this intentional? If so, let's use KOKKOSSPARSE_CUSPARSE_SAFE_CALL, otherwise let's deprecate it and use KOKKOSSPARSE_IMPL_CUSPPARSE_SAFE_CALL.

@lucbv
Copy link
Contributor

lucbv commented Oct 10, 2024

I think the last option makes sense: KOKKOSSPARSE_IMPL_CUSPARSE_SAFE_CALL, eventually we should review what we are doing for other libraries like rocSPARSE, rocBLAS, etc...

@cwpearson
Copy link
Contributor Author

cwpearson commented Oct 10, 2024

Interestingly those other ones are either not KOKKOS_ or they have IMPL in the name, in which case I feel happy to just rename them. This is the one special case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants