You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Let's be good ecosystem partners and prefix this with KOKKOSSPARSE_ instead.
I personally don't think this should be part of our interface. Is this intentional? If so, let's use KOKKOSSPARSE_CUSPARSE_SAFE_CALL, otherwise let's deprecate it and use KOKKOSSPARSE_IMPL_CUSPPARSE_SAFE_CALL.
The text was updated successfully, but these errors were encountered:
I think the last option makes sense: KOKKOSSPARSE_IMPL_CUSPARSE_SAFE_CALL, eventually we should review what we are doing for other libraries like rocSPARSE, rocBLAS, etc...
Interestingly those other ones are either not KOKKOS_ or they have IMPL in the name, in which case I feel happy to just rename them. This is the one special case.
kokkos-kernels/sparse/src/KokkosSparse_Utils_cusparse.hpp
Lines 67 to 69 in c7df61d
Let's be good ecosystem partners and prefix this with
KOKKOSSPARSE_
instead.I personally don't think this should be part of our interface. Is this intentional? If so, let's use
KOKKOSSPARSE_CUSPARSE_SAFE_CALL
, otherwise let's deprecate it and useKOKKOSSPARSE_IMPL_CUSPPARSE_SAFE_CALL
.The text was updated successfully, but these errors were encountered: