Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat subviews correctly #77

Open
aprokop opened this issue Jun 8, 2024 · 0 comments
Open

Treat subviews correctly #77

aprokop opened this issue Jun 8, 2024 · 0 comments

Comments

@aprokop
Copy link
Contributor

aprokop commented Jun 8, 2024

Need to make sure things like

irecv(Kokkos::subview(view, std::make_pair(i, j)), ...);

compile and work correctly. Currently it doesn't because of expects an lvalue for 1st argument. It could be as easy as using const ref any time a view is passed instead of a non-const reference.

Need to go through functions and do updates, and add testing.

Would probably also need to add tests for unmanaged views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant