-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix relative include in mpi.hpp #120
Comments
PR #122 should fix this. If we merge it, I have another PR ready that updates all the includes with the Additionally, @cedricchevalier19 mentioned that having relative path includes may improve compilation speed. |
PR #122 was merged; how best to proceed? |
I can make a quick PR replacing all KokkosComm-related includes with the However, in a discussion with @cedricchevalier19, he mentioned that these kinds of includes may have a negative impact on compile times (see previous message in this thread). I didn't notice any slowdowns for KokkosComm builds but we may want to take that into consideration before changing all the paths. |
Removes all instances of relative paths in favor of system include-style syntax: `<KokkosComm/...>
kokkos-comm/src/KokkosComm/mpi/mpi.hpp
Line 21 in a968a13
The text was updated successfully, but these errors were encountered: