From 27323c2a26fbeb3b55cf2bfb4bd2acbc261197c2 Mon Sep 17 00:00:00 2001 From: Cedric Chevalier Date: Wed, 12 Jun 2024 23:32:13 +0200 Subject: [PATCH 1/2] Remove an "unused parameter" warning --- unit_tests/test_allgather.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unit_tests/test_allgather.cpp b/unit_tests/test_allgather.cpp index 0627bfb5..8671039c 100644 --- a/unit_tests/test_allgather.cpp +++ b/unit_tests/test_allgather.cpp @@ -40,7 +40,7 @@ void test_allgather_0d() { // fill send buffer Kokkos::parallel_for( - sv.extent(0), KOKKOS_LAMBDA(const int i) { sv() = rank; }); + sv.extent(0), KOKKOS_LAMBDA(const int) { sv() = rank; }); KokkosComm::allgather(Kokkos::DefaultExecutionSpace(), sv, rv, MPI_COMM_WORLD); From e89b4c87eaf1b6c831725ddb853e842920105927 Mon Sep 17 00:00:00 2001 From: Cedric Chevalier Date: Wed, 12 Jun 2024 23:37:38 +0200 Subject: [PATCH 2/2] Warnings as errors in the CI --- .github/workflows/linux.yaml | 4 ++-- .github/workflows/osx.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/linux.yaml b/.github/workflows/linux.yaml index 2b2a1f99..d5cb68ed 100644 --- a/.github/workflows/linux.yaml +++ b/.github/workflows/linux.yaml @@ -44,7 +44,7 @@ jobs: cmake --build "$KOKKOS_BUILD" --parallel $(nproc) -t install - name: Build KokkosComm run: | - cmake -S "$COMM_SRC" -B "$COMM_BUILD" -DKokkos_ROOT="$KOKKOS_INSTALL" -DCMAKE_BUILD_TYPE=Release -DKokkosComm_ENABLE_TESTS=ON -DKokkosComm_ENABLE_PERFTESTS=ON + cmake -S "$COMM_SRC" -B "$COMM_BUILD" -DCMAKE_CXX_FLAGS="-Werror" -DKokkos_ROOT="$KOKKOS_INSTALL" -DCMAKE_BUILD_TYPE=Release -DKokkosComm_ENABLE_TESTS=ON -DKokkosComm_ENABLE_PERFTESTS=ON VERBOSE=1 cmake --build "$COMM_BUILD" - name: Test KokkosComm run: | @@ -76,7 +76,7 @@ jobs: cmake --build "$KOKKOS_BUILD" --parallel $(nproc) -t install - name: Build KokkosComm run: | - cmake -S "$COMM_SRC" -B "$COMM_BUILD" -DKokkos_ROOT="$KOKKOS_INSTALL" -DCMAKE_BUILD_TYPE=Debug -DKokkosComm_ENABLE_TESTS=ON -DKokkosComm_ENABLE_PERFTESTS=ON + cmake -S "$COMM_SRC" -B "$COMM_BUILD" -DCMAKE_CXX_FLAGS="-Werror" -DKokkos_ROOT="$KOKKOS_INSTALL" -DCMAKE_BUILD_TYPE=Debug -DKokkosComm_ENABLE_TESTS=ON -DKokkosComm_ENABLE_PERFTESTS=ON VERBOSE=1 cmake --build "$COMM_BUILD" - name: Test KokkosComm run: | diff --git a/.github/workflows/osx.yaml b/.github/workflows/osx.yaml index 61927985..97d58f74 100644 --- a/.github/workflows/osx.yaml +++ b/.github/workflows/osx.yaml @@ -38,7 +38,7 @@ jobs: cmake --build "$KOKKOS_BUILD" --parallel $(nproc) -t install - name: Build KokkosComm run: | - cmake -S "$COMM_SRC" -B "$COMM_BUILD" -DKokkos_ROOT="$KOKKOS_INSTALL" -DCMAKE_BUILD_TYPE=Debug -DKokkosComm_ENABLE_TESTS=ON -DKokkosComm_ENABLE_PERFTESTS=ON + cmake -S "$COMM_SRC" -B "$COMM_BUILD" -DCMAKE_CXX_FLAGS="-Werror" -DKokkos_ROOT="$KOKKOS_INSTALL" -DCMAKE_BUILD_TYPE=Debug -DKokkosComm_ENABLE_TESTS=ON -DKokkosComm_ENABLE_PERFTESTS=ON VERBOSE=1 cmake --build "$COMM_BUILD" - name: Test KokkosComm run: | @@ -70,7 +70,7 @@ jobs: cmake --build "$KOKKOS_BUILD" --parallel $(nproc) -t install - name: Build KokkosComm run: | - cmake -S "$COMM_SRC" -B "$COMM_BUILD" -DKokkos_ROOT="$KOKKOS_INSTALL" -DCMAKE_BUILD_TYPE=Release -DKokkosComm_ENABLE_TESTS=ON -DKokkosComm_ENABLE_PERFTESTS=ON + cmake -S "$COMM_SRC" -B "$COMM_BUILD" -DCMAKE_CXX_FLAGS="-Werror" -DKokkos_ROOT="$KOKKOS_INSTALL" -DCMAKE_BUILD_TYPE=Release -DKokkosComm_ENABLE_TESTS=ON -DKokkosComm_ENABLE_PERFTESTS=ON VERBOSE=1 cmake --build "$COMM_BUILD" - name: Test KokkosComm run: |