Don't use magic "behind the curtains"

[kemo]

ORM shouldn't rely on magic methods natively but use the methods for setting / getting instead. Examples;
$this->{$name} = $var;
$this->{$key}->values($values[$key], $column);
$this->$column = $values[$column];
$data[$var] = $this->{$var};
$this->{$property} = $value;

This obviously doesn't apply to properties which aren't magic anyway

[kemo]

Any opinions?

[evanpurkhiser]

I'm a little bit confused by your example. Are you saying end-users should use ORM::get and ORM::set and we remove the magic methods that allow you to act on columns as if they were properties of the object?

// So instead of this
$my_model->some_column = 'value';

// It would be
$my_model->set('some_column', 'value');

Or are you saying internally we should never use magic methods? (In that case I think I would agree)

[kemo]

Or are you saying internally we should never use magic methods?

@evanpurkhiser exactly, sorry if I wasn't clear enough

[evanpurkhiser]

This sounds good to me then. I can't think of any reasons not to use the get/set methods. 👍

[arteymix]

Yeah, even magic methods are mapped to get and set, so this would lighten the call stack. It would also be more flexible when dealing with uncommon column name containing spaces.