-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huge dependency #39
Comments
@Merri Thanks for reporting this. I have an idea what is causing this. May I ask, what other reasons made you switch? |
A feature that is missing from Helmet is that you can't easily access the rendered values, you have to use Another thing I don't like with Helmet is that it doesn't re-use matching existing meta tags, or check if one of the tags to remove is exactly the same that is going to be added. This means it makes unnecessary DOM manipulation on each route change. |
I swapped from
react-document-meta
toreact-helmet
, but while doing that I noticed there appears to be something wrong with the dependencies as when I usedreact-document-meta
my uglified production bundle size was 195 kB while after switching toreact-helmet
the bundle size dropped down to 65 kB. This change is the only change I made between bundles, so there are certainly some dependency issues that should be resolved. I didn't investigate what causes the issue.The text was updated successfully, but these errors were encountered: