Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using .cfg files #128

Open
RodrigoPrestes opened this issue Oct 2, 2024 · 5 comments
Open

Using .cfg files #128

RodrigoPrestes opened this issue Oct 2, 2024 · 5 comments

Comments

@RodrigoPrestes
Copy link

I would like to configure some settings (like integer scaling, save location) but those are not defined on the addon settings.xml.
RetroArch have a cfg file where it stores all configurations, and we also have the possibility of creating a override, for example per core.

Is there any way to use a cfg file on the addon?
Or to configure options in some other way?

@garbear
Copy link
Member

garbear commented Oct 3, 2024

Kodi has a Settings window, which will apply to all add-ons, is that what you mean? If a setting is missing, it can be requested.

@RodrigoPrestes
Copy link
Author

I believe the addon only has one setting.
I would like to request some options, looking at RetroArch's config file they are:

  • video_scale_integer
  • savestate_auto_save
  • savestate_auto_load
  • savefile_directory
  • savestate_directory

Let me know if those should be a new issue, or even multiple issues.

@garbear
Copy link
Member

garbear commented Oct 4, 2024

I believe Kodi already has integer scaling: xbmc/xbmc#18194

As for the others, a good spot for new game settings would be Settings -> Games -> General. However, we should be aware of "settings proliferation" and rely on sensible defaults where possible. Currently, Kodi uses the "userdata" folder for all config and writable files. We would have to weigh the advantage of user-configurable save directories (especially when Kodi already has an existing directory structure) against settings proliferation.

Autosave/autoload toggles are valid requests. What would the labels be in the settings UI?

@RodrigoPrestes
Copy link
Author

About integer scaling

Will test it!
Looking at the PR it should only affect games so this might do it.


About save locations

My problem with saves as they are now is that they use a single directory under userdata for saves of all cores.
It's very common to have it in other places like the RetroArch defaults on the ROM directory or by core like Onion OS (I could be mistaken but I believe RetroPie also works by system as well).

However, I don't want to break any established rule by Kodi, so let me know if this is something one would had to compromise when using the addon.


About auto save states labels

RetroArch uses the label "Auto Save State" and "Auto Load State".

image

@RodrigoPrestes
Copy link
Author

About integer scaling

Could not test existing option, it was hidden at some point: linux.xml#L218


About save locations

What if the addon had a setting to save by system/core and then implement by just appending to the current save location?
That way we comply with Kodi rules by staying on the profile directory while still having the saves organized on separate folders.


About auto save states

Haven't tested this but it appears Kodi already have (at least a setting for) this: settings.xml#L2671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants