Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only collection issuer can edit NFT #11196

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

(please remove design and QA checks below if not needed)

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image image image

@Jarsen136 Jarsen136 requested a review from a team as a code owner November 28, 2024 21:29
@Jarsen136 Jarsen136 requested review from vikiival and hassnian and removed request for a team November 28, 2024 21:29
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 44e74a2
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6748e4b6ce500e0008a0d3c4
😎 Deploy Preview https://deploy-preview-11196--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Nov 28, 2024

@hassnian hassnian added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Nov 29, 2024
@vikiival vikiival added this pull request to the merge queue Nov 29, 2024
Merged via the queue into kodadot:main with commit 2b64376 Nov 29, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Nft that does not belong to the current user
3 participants