feat: code checker support loadTable
#11356
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
That's perfect. Yes, the issue is solved exactly, and I tested it and there is no problem. Thanks for your attention. |
…d check for remote files
…ssnian/nft-gallery into issue-code-checker-load-table
hassnian
requested review from
preschian and
Jarsen136
and removed request for
a team
| useEventListener(window, 'message', async (res) => { | ||
| const hash = res.data.payload.hash | ||
| if ( | ||
| res.data?.type === 'kodahash/render/completed' |
There was a problem hiding this comment.
why? It's necessary to detect the moment when the rendering process is finished.
There was a problem hiding this comment.
it's used to calculate the average time per variation
There was a problem hiding this comment.
In case some art does not trigger the complete event properly, why not calculate the time based on the event triggered?
There was a problem hiding this comment.
why not calculate the time based on the event triggered?
I don't understand, the only event that the canvas triggers atm is kodahash/render/completed , viki suggested adding a kodahash/render/started since some drops took more time to trigger the former but we only have one atm
can you comment some code, maybe that helps me better understand what you mean
|
|
That's perfect, this is totally working. The problem is solved. Only I got an error which is on my code, and I need to recheck the code. But other things work. |
|
|
hassnian
added
the
S-works-for-me-✅
PR Type
Context
loadTablein code-checker #11359Screenshot 📸