Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component]: CheckboxGroup #310

Open
jer3m01 opened this issue Jan 18, 2024 · 3 comments · May be fixed by #502
Open

[Component]: CheckboxGroup #310

jer3m01 opened this issue Jan 18, 2024 · 3 comments · May be fixed by #502
Labels
SolidHack Participating component for https://hack.solidjs.com/categories-challenges

Comments

@jer3m01
Copy link
Member

jer3m01 commented Jan 18, 2024

No description provided.

@jer3m01 jer3m01 converted this from a draft issue Jan 18, 2024
@jer3m01 jer3m01 added the SolidHack Participating component for https://hack.solidjs.com/categories-challenges label Oct 1, 2024
@Shubhdeep12
Copy link
Contributor

Hey @jer3m01, quick question (this might be a bit silly):

Which one should we prefer?

<CheckboxGroup>
  <CheckboxGroup.Item>
    <CheckboxGroup.ItemInput />
    <CheckboxGroup.ItemLabel />
    <CheckboxGroup.ItemDescription />
  </CheckboxGroup.Item>
  <CheckboxGroup.Description />
</CheckboxGroup>

OR

<CheckboxGroup>
  <Checkbox ... />
  <Checkbox ... />
</CheckboxGroup>

@jer3m01
Copy link
Member Author

jer3m01 commented Oct 17, 2024

Which one should we prefer?

Following the same design as DropdownMenu, Menubar and NavigationMenu it should be:

<CheckboxGroup>
  <CheckboxGroup.Item>
    <CheckboxGroup.ItemInput />
    <CheckboxGroup.ItemLabel />
    <CheckboxGroup.ItemDescription />
  </CheckboxGroup.Item>
  <CheckboxGroup.Description />
</CheckboxGroup>

with CheckboxGroup.Item* being re-exports from Checkbox.

@Shubhdeep12
Copy link
Contributor

great!
thanks for the resposne

@Shubhdeep12 Shubhdeep12 linked a pull request Oct 17, 2024 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SolidHack Participating component for https://hack.solidjs.com/categories-challenges
Projects
Kobalte - Roadmap
Status: 📚 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Checkbox group component Shubhdeep12/kobalte
2 participants
@jer3m01 @Shubhdeep12