mame_libretro.so core segfaults on start

[ben-willmore]

Knulli build version

41-dev-a1102db1e2 2024/11/07 19:52

Your architecture

RG35XX H

Issue description

Games using the mame_libretro.so core crash on start in current alpha builds. This worked fine on the 2024/07/21 release.

Detailed reproduction steps

Add a BBC Micro rom to the roms/bbc/ directory and attempt to run it. Emulator crashes.

Details of any attempts to fix this yourself

Copy /usr/lib/libretro/mame_libretro.so from the 2024/07/21 release. This fixes the problem.

Details of any modifications you have made to Knulli.

None

Logs and data

No response

[ben-willmore]

Still broken on Firefly

[SuperBadger77]

Following. Can't get Acorn Electron or BBC Micro to work on FIrefly on my RG40XX.

[ben-willmore]

Workaround: https://drive.google.com/file/d/1tvfbXXoUZ85FSIlkKgGXsYWe4XwLG_qG/view?usp=share_link
custom.sh -> /userdata/system/custom.sh
mame_libretro.so -> /userdata/mame_fix/mame_libretro.so
Then reboot

[SuperBadger77]

Workaround: https://drive.google.com/file/d/1tvfbXXoUZ85FSIlkKgGXsYWe4XwLG_qG/view?usp=share_link custom.sh -> /userdata/system/custom.sh mame_libretro.so -> /userdata/mame_fix/mame_libretro.so Then reboot

I can confirm the work around works on my RG40XX H.

[ben-willmore]

This is a regression between version 0.265 of mame_libretro.so and version 0.268 on knulli. It would be helpful to know if version 0.268 also has this problem on other platforms, or whether it is specific to the build in knulli. [The version number can be seen in /userdata/system/logs/es_launch_stderr.log after running and quitting a mame game.]

[ben-willmore]

Alternative workaround, without the big download, and using mame 0.268, but also without MAME artwork:

/userdata/system/custom.sh:

#!/bin/bash

VERSION=`cat /userdata/system/data.version | awk {'print $1}'`
echo Knulli version is $VERSION

if [[ $VERSION == '41' ]] || [[ $VERSION == 'firefly' ]]; then
  echo Disabling MAME artwork to fix segfault
  CFG=/usr/lib/python3.11/site-packages/configgen/generators/libretro/libretroMAMEConfig.py
  mv "${CFG}" "${CFG}.bak"
  sed "s/!= 'same_cdi'/== 'DISABLED'/" "${CFG}.bak" > "${CFG}"
fi

[ben-willmore]

This is now confirmed fixed in libretro -- libretro/mame#513 -- but we should leave this open because the workaround will be needed until this filters through to a knulli build.