Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targetSource endpoint for fetching annotations based on targetSource #60

Open
svandaalen opened this issue Jul 10, 2024 · 2 comments
Assignees

Comments

@svandaalen
Copy link

svandaalen commented Jul 10, 2024

To integrate knaw-huc/textannoviz#128 into TAV, TAV needs an endpoint in Broccoli that allows for fetching of annotations based on the target.source.

A quick recap of what we discussed yesterday:

The AR search query to fetch the Resolutions that belong to canvasId https://images.diginfra.net/api/pim/iiif/9c33830d-797f-4a14-a474-5017466700c7/canvas/93504486-522c-42f6-8001-d13829692f5c is:

{
  "target.type": "Canvas",
  "target.source": "https://images.diginfra.net/api/pim/iiif/9c33830d-797f-4a14-a474-5017466700c7/canvas/93504486-522c-42f6-8001-d13829692f5c",
  "body.type": "Resolution"
}

Bram noted that "target.type": "Canvas", could be left out. He also already created an index in AR to speed up this query.

@hayco
Copy link
Contributor

hayco commented Jul 10, 2024

@brambg mentioned that target.type is not even necessary in the query.
This could mean that we can abstract from calling this 'get by canvasID' to 'get by targetSource' or something similar, allowing for more use cases to be handled by the same endpoint.

@svandaalen svandaalen changed the title Add canvasId endpoint for fetching annotations based on canvasId Add targetSource endpoint for fetching annotations based on targetSource Jul 10, 2024
@brambg
Copy link
Contributor

brambg commented Jul 10, 2024

Met de huidige target.type lijkt me dat geen probleem: de target.source van het ene target.type wordt nooit bij een ander target.type gebruikt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants