Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the webhook ports used for KnativeEventing and KnativeServing deployments #1942

Open
zhugnou opened this issue Dec 16, 2024 · 1 comment

Comments

@zhugnou
Copy link

zhugnou commented Dec 16, 2024

Problem
When using AWS EKS as a Kubernetes platform and with Calico as the CNI, we are required to run certain pods on the host network. There is currently no way to override the default webhook port values for each Deployment when using the Knative operator to create the KnativeServing and KnativeEventing resources. As a result, we must configure taints and tolerations for our pods and nodes so that the host network pods are scheduled on their own individual nodes, which removes the conflict of needing to run on a specific port, but introduces additional cost and management for the dedicated EC2 instances that are running the pods. A specific example of this when using EKS + Calico is the KnativeEventing eventing-webhook and imc-controller pods needing to be run with hostNetwork: true and only one Node available.

Persona:
Which persona is this feature for?
System Operator

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.
Override the default webhook port for KnativeEventing deployments and testing to see if the eventing-webhook and imc-controller pods can be run on the same Node when hostNetwork: true

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.

@houshengbo
Copy link
Contributor

@zhugnou Feel free to open a PR for this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants