Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntegrationSink CRD #8304

Merged
merged 20 commits into from
Nov 22, 2024
Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 5, 2024

Related to #8185

Proposed Changes

  • Adding new IntegrationSink CRD and tests. As alwasys, there is lot of boilerplate code when on-bording new component

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Add IntegrationSink for supporting generic event sinks based on Apache Camel Kamelets.

Docs

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test-and-release Test infrastructure, tests or release size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2024
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2024
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2024
@matzew matzew force-pushed the add_integration_sink_rework branch 2 times, most recently from ba47495 to 376a3e8 Compare November 20, 2024 14:25
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 49.78992% with 239 lines in your changes missing coverage. Please review.

Project coverage is 64.23%. Comparing base (5ad7dab) to head (9d7e051).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/integration/sink/integrationsink.go 38.46% 79 Missing and 17 partials ⚠️
pkg/reconciler/integration/sink/controller.go 0.00% 58 Missing ⚠️
.../apis/sinks/v1alpha1/integration_sink_lifecycle.go 9.30% 39 Missing ⚠️
...iler/integration/sink/resources/container_image.go 72.80% 31 Missing ⚠️
...apis/sinks/v1alpha1/integration_sink_validation.go 79.54% 7 Missing and 2 partials ⚠️
...g/apis/sinks/v1alpha1/integration_sink_defaults.go 0.00% 3 Missing ⚠️
pkg/apis/sinks/v1alpha1/integration_sink_types.go 66.66% 2 Missing ⚠️
cmd/controller/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8304      +/-   ##
==========================================
- Coverage   64.53%   64.23%   -0.31%     
==========================================
  Files         380      390      +10     
  Lines       22772    23248     +476     
==========================================
+ Hits        14697    14934     +237     
- Misses       7300     7520     +220     
- Partials      775      794      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@matzew matzew force-pushed the add_integration_sink_rework branch 2 times, most recently from 00b2d0b to 0a3f64e Compare November 22, 2024 12:03
@matzew matzew changed the title WIP: Add integration sink Add integration sink Nov 22, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2024
@matzew matzew changed the title Add integration sink Add IntegrationSink CRD Nov 22, 2024
Clean ups
Adding tests for reconciler

Signed-off-by: Matthias Wessendorf <[email protected]>
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: integration-sink-server-tls
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are actually not using this.

In a follow up PR, we will generate these Certificate manifest for each IntegrationSource instance (their Service).

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

namespace: {{ .namespace }}
{{ if .annotations }}
{{ range $key, $value := .annotations }}
{{ $key }}: {{ $value }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this helps when having annotations that are "boolean" but need to be represented as strings

Suggested change
{{ $key }}: {{ $value }}
{{ $key }}: "{{ $value }}"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah ... I fixed similar before, last week.

Will update it. eventually

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
Copy link

knative-prow bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7176ce6 into knative:main Nov 22, 2024
32 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants