Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Remove hard coded images from go source files #651

Open
scothis opened this issue Jul 19, 2019 · 0 comments
Open

Remove hard coded images from go source files #651

scothis opened this issue Jul 19, 2019 · 0 comments
Labels
kind/bug Something isn't working

Comments

@scothis
Copy link
Contributor

scothis commented Jul 19, 2019

Expected Behavior

Knative Build should only consume images declared in its configuration. This enables tools to scan what images will be consumed, and provide alternate images as needed

Actual Behavior

The gcr.io/cloud-builders/gcs-fetcher:latest image is defined in the source code. The other image arguments have stub values with actual values defined in the controller deployment. Because the image is not also specified in the yaml configuration, it requires special foreknowledge of Knative Build in order to properly configure the controller.

Additional Info

gcsFetcherImage = flag.String("gcs-fetcher-image", "gcr.io/cloud-builders/gcs-fetcher:latest",

@knative-prow-robot knative-prow-robot added the kind/bug Something isn't working label Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants