Jib: Adds init script to use with any Gradle project. #68
Conversation
|
@coollog: GitHub didn't allow me to request PR reviews from the following users: loosebazooka. Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @coollog. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
||
| ### Speed up builds | ||
|
|
||
| See [Speed up builds](#speed-up-builds). |
There was a problem hiding this comment.
Even though it's annoying to have two copies, it might be helpful to be explicit about the steps to speed up Gradle builds specifically. I'm thinking if I'm a heavy Gradle user and doesn't know anything about Maven, I don't want to have to figure out which parts of the Maven-specific "speeding up builds" doc apply to me and which don't.
Let me know if that's a silly thought, and that Gradle developers would necessarily know enough about Maven to figure it out, I don't know the Javas.
| @@ -16,15 +16,49 @@ spec: | |||
| steps: | |||
| - name: build-and-push | |||
| image: gcr.io/cloud-builders/gradle | |||
| command: | |||
There was a problem hiding this comment.
This might indicate that we want a jib-gradle builder image that includes these files (and any future ones), without having to squeeze them into the build template.
If we go that route, my personal preference would be to base that image FROM gradle and not rely on the poorly-supported gcr.io/cloud-builders/gradle image. (Same with maven, tbh). That can happen in a later CL though if you'd prefer.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: coollog, saturnism If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #63
The init script auto-applies
jib-gradle-pluginto the Gradle project.Also fixes the caching for the
jib-gradleBuildTemplate./cc @loosebazooka
/cc @saturnism