Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #626 panic on invalid tls config in secret #627

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tdeverdiere
Copy link
Contributor

Fixes #626

Proposed Changes

  • Add a panic message if redis tls config is invalid (in source adapter)
  • Fix condition of affecting tls certificate and redis config when they are empty/invalid

Release Note

🐛 Fix RedisStreamSource when no Redis TLS certificate is given

Docs
#626

Copy link

knative-prow bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tdeverdiere
Once this PR has been reviewed and has the lgtm label, please assign pierdipi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from matzew October 21, 2024 11:04
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 21, 2024
@knative-prow knative-prow bot requested a review from pierDipi October 21, 2024 11:04
@tdeverdiere tdeverdiere force-pushed the fix-626-panic-on-invalid-tls-config-in-secret branch from 75fa8da to 3e4a61a Compare October 21, 2024 12:55
@tdeverdiere tdeverdiere marked this pull request as draft October 21, 2024 14:22
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024
@tdeverdiere tdeverdiere marked this pull request as ready for review November 7, 2024 14:16
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic(nil) when the TLS certificate in Secret is the default one
1 participant