Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import and update shell completions #55

Open
evelikov opened this issue Jul 17, 2024 · 5 comments
Open

Import and update shell completions #55

evelikov opened this issue Jul 17, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@evelikov
Copy link
Collaborator

evelikov commented Jul 17, 2024

Currently we have the bash completion in-tree, while the zsh lives in the upstream zsh project itself. Both of those are somewhat outdated.

A hand-wavy todo/ideas list:

  • import the zsh completion
  • compare against the respective programs (manual pages are outdated Update the man pages against the respective tool #57) and update
    • should we have completion for the deprecated options?
  • add note to the readme/hacking so we don't update them in the future
  • after 1-2 kmod releases poke upstream zsh to drop their variant

Soft depends on #56

@lucasdemarchi lucasdemarchi added the enhancement New feature or request label Jul 17, 2024
@evelikov
Copy link
Collaborator Author

evelikov commented Sep 8, 2024

Seems like the in-tree one is very bare-bones. The extra ones are in third-party repo ...

Might be worth pulling them all together, fish anyone?

@evelikov
Copy link
Collaborator Author

evelikov commented Sep 9, 2024

Kicked off some upstream discussions, wrt copyright license etc

Some of the responses are better than others. In addition the quality and coverage are quite varying. I wonder if writing something from scratch won't be faster...

@evelikov
Copy link
Collaborator Author

evelikov commented Sep 9, 2024

Tl:Dr

  • one has a custom license - SPDX MIT-Modern-Variant but not quite
  • some responses aren't clear what/how to give attribution to existing authors/copyright holders
  • one implementation has local cache, which expires after 1 week

@firasuke
Copy link

I'd like to point out that specifying --without-bashcompletiondir or --with-bashcompletiondir=no does not disable the installation of the completion scripts, and instead creates a no or ${DESTDIR}no directory which contains the completion scripts.

Is this behavior intended? Or should I open a separate issue to track this problem?

Thanks for your time.

@evelikov
Copy link
Collaborator Author

AFAICT disabling the shell completions was never supported with the autotools build.

For meson we got the means with 4670f4b and I don't plan on adding autotools equivalent, since the goal is to remove the latter with kmod v35 (as per the README).

Patches welcome though o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants