Stevenabreu7 nir #16
Merged
Stevenabreu7 nir #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """Converts a Spyx network to a NIR graph.""" | ||
| # construct the edge list for the NIRGraph | ||
| keys = list(spyx_pytree.keys()) | ||
| edges = [(keys[i], keys[i + 1]) for i in range(len(keys) - 1)] # assume linear connectivity |
There was a problem hiding this comment.
will the keys of the pytree always be ordered? if not, the edges of the NIR graph would be incorrect, wouldn't they?
|
From my understanding/experience yes, they are always ordered.
…On Wed, Oct 25, 2023, 17:01 Steven Abreu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spyx/nir.py
<#16 (comment)>:
> +
+ elif isinstance(node, nir.Scale): # not needed atm
+ pass
+
+ elif isinstance(node, nir.Delay): # not needed atm
+ pass
+
+ elif isinstance(node, nir.Threshold): # not needed atm
+ pass
+
+
+def to_nir(spyx_pytree, input_shape, output_shape) -> nir.NIRGraph:
+ """Converts a Spyx network to a NIR graph."""
+ # construct the edge list for the NIRGraph
+ keys = list(spyx_pytree.keys())
+ edges = [(keys[i], keys[i + 1]) for i in range(len(keys) - 1)] # assume linear connectivity
will the keys of the pytree always be ordered? if not, the edges of the
NIR graph would be incorrect, wouldn't they?
—
Reply to this email directly, view it on GitHub
<#16 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMG7YKF25CSOGWLOQXGVZMTYBEZVVAVCNFSM6AAAAAA6PCSPCWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJXG42DQMRSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.