Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E2E Enhancement] Use kmeshctl to manage waypoints #939

Open
YaoZengzeng opened this issue Oct 10, 2024 · 0 comments
Open

[E2E Enhancement] Use kmeshctl to manage waypoints #939

YaoZengzeng opened this issue Oct 10, 2024 · 0 comments
Labels
kind/enhancement New feature or request

Comments

@YaoZengzeng
Copy link
Member

What would you like to be added:

Now we have cli tool kmeshctl and its subcommand kmeshctl waypoint can be used to manage waypoints.

Currently in E2E tests, the gateway API is still direclty called to manage waypoints (https://github.com/kmesh-net/kmesh/blob/main/test/e2e/main_test.go#L274). In fact the code is repeated with kmeshctl waypoint, so we can direcly call kmeshctl waypoint to manage it.

Why is this needed:

Avoid code redundancy
@YaoZengzeng YaoZengzeng added the kind/enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YaoZengzeng