Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated manual entrypoint creation results in incorrect label parenting #4

Open
kmeisthax opened this issue Feb 22, 2021 · 0 comments

Comments

@kmeisthax
Copy link
Owner

When a new parent label is created in between a parent and it's child, the child's parent is not updated to the new parent.

Example: In Telefang, disassemble $A2A - this creates a child block at $A3D. Then disassemble $A34 - the label .LOC_A3D will still be parented to ENTER_A2A despite not being actually local anymore.

More generally we should enforce a restriction that all local labels must be parented to the last parent block; and furthermore prevent creation of local labels on symbols that have nonlocal crossreferences. Some assemblers do not allow you to use non-local symbols as global symbols (e.g. ENTER_A34.LOC_A3D)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant