Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option to TrySplits when nChanged hits a certain threshold #32

Open
thesamovar opened this issue Jan 8, 2015 · 2 comments
Open

Comments

@thesamovar
Copy link
Member

Currently, TrySplits is tried when nChanged gets to 0, but actually it would be sensible to have a higher threshold. This could be a parameter.

Typically, TrySplits will lead to much larger nChanged, so this would potentially save quite a lot of computation.

@thesamovar
Copy link
Member Author

Note that we don't want to repeatedly TrySplits, so we have to keep track of the previous value of nChanged and only TrySplits if nChanged<=threshold<oldnChanged.

@nsteinme
Copy link

Could the right approach be to check whether TrySplits did actually come up with any new clusters - and if not, to ignore the threshold and let nChanged go to zero (before TrySplits a final time)?

Generally I think this is a very good enhancement idea!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants