Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Solidity good practices #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update Solidity good practices #20

wants to merge 3 commits into from

Conversation

AndreiMVP
Copy link

Added a couple of new points:

  • Don't use separate functions/inheritance unless you have to
  • Be conservative with the code you write
  • When transferring ETH, send is usually better than call

@AndreiMVP AndreiMVP requested a review from clesaege June 4, 2022 17:54
@jaybuidl
Copy link
Member

jaybuidl commented Jun 6, 2022

Also add a mention against using Solidity custom errors.

Otherwise LGTM.

@AndreiMVP AndreiMVP changed the title Update Solidity good practices added "e.g. custom errors" Jun 7, 2022
@AndreiMVP AndreiMVP changed the title added "e.g. custom errors" Update Solidity good practices Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clesaege clesaege Awaiting requested review from clesaege

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreiMVP @jaybuidl