Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should all dates in db be type Date or String #71

Open
klequis opened this issue Jun 2, 2021 · 0 comments
Open

Should all dates in db be type Date or String #71

klequis opened this issue Jun 2, 2021 · 0 comments
Labels
critical critical issue enhancement New feature or request

Comments

@klequis
Copy link
Owner

klequis commented Jun 2, 2021 •
edited
Loading

Currently, dates are stored in db as strings. Should they be dates?

One reason to make them dates in db is when filtering by year and/or month, the string for each transaction (currently >2,700) needs to be converted into a date. See: private-money-client: src/features/selectors/txTblSelectors/txTblSelectors.js.

Impact on code (changes)

Not evaluated yet but possibly considerable.
@klequis klequis added enhancement New feature or request critical critical issue labels Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
critical critical issue enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@klequis