-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support contextBridge api #235
Comments
This is really crucial for security. @matmalkowski are there any plans for this? |
@musou1500 @slapbox I think we could support contextBridge in v2, since right now communication is all done with ipc ( |
@matmalkowski any update on a timeline for v2? Do you think this might be addressed once v2 is out? We're really looking forward to its release! |
Yeah, I actually got an issue already created for that: #289 , just slightly different naming. Right now I'm quite busy with other stuff, so it is hard to tell when this could be incorporated into v2, but the general plan is to include that in the version 2, finish up the documentation and create a stable release afterwards. If you are interested, you may take a look at the issue, it links to possible implementation in the fork of that project, and raise a PR to v2 if you have some spare time to implement it |
Closing as duplicate of #289, we can continue all discussions in that ticket 👍🏻 |
Is your feature request related to a problem? Please describe.
we need to use preload script or
nodeIntegration
option to useelectron-redux
.I think preload script is ideal for security perspective.
I often load application hosted on local server while developing(I believe it is common usecase).
but application can not be loaded as preload script in this way.
It requires us to additional branch.
Describe the solution you'd like
I propose to support
contextBridge
api.I am assuming expose simple api that communicate with main process using
ipcRenderer
api through contextBridge.in this way, application on renderer process can use
electron-redux
regardless it is loaded through local server or preload script.The text was updated successfully, but these errors were encountered: