Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make a test failing if the Cairo VM reverts #524

Open
ClementWalter opened this issue Oct 10, 2023 · 2 comments
Open

feat: make a test failing if the Cairo VM reverts #524

ClementWalter opened this issue Oct 10, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ClementWalter
Copy link
Member

Feature Request

Describe the Feature Request

Some tests are passing because the post state is the right one, but the Cairo VM reverts.
We should assert as well that the Cairo VM exit 0.

Additional Context

The Cairo VM should not revert when used regularly, ie when facing a REVERT opcode (see kkrt-labs/kakarot#766).

We will still have few revert cases (Stack overflow, underflow) that we may want to handle as well (need to check what geth does).
@ClementWalter ClementWalter added the enhancement New feature or request label Oct 10, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Oct 10, 2023
@ClementWalter
Copy link
Member Author

is it still to be done @greged93 ?

@greged93
Copy link
Contributor

@enitrat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Kakarot on Starknet
Status: 🆕 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eugypalu @ClementWalter @greged93