Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename MaybeRelocatable to SegmentValue #53

Closed
zmalatrax opened this issue May 2, 2024 · 0 comments · Fixed by #56
Closed

refactor: rename MaybeRelocatable to SegmentValue #53

zmalatrax opened this issue May 2, 2024 · 0 comments · Fixed by #56
Assignees

Comments

@zmalatrax
Copy link
Collaborator

MaybeRelocatable represents the value a memory cell can take during a run of the VM, before the relocation phase near the end.
MaybeRelocatableis essentially an union type: Relocatable | Felt.

But the name MaybeRelocatable doesn't provide more sense, details or anything to it. Therefore, it should renamed to something more meaningful, such as SegmentValue. The same way, the attribute data in the class Memory should be replaced by values.
All the related occurences of MaybeRelocatable and memory.data in variable names, methods etc. should be renamed consequently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant