Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript conversion + big changes. #62

Open
UrielCh opened this issue Jun 10, 2022 · 13 comments
Open

Typescript conversion + big changes. #62

UrielCh opened this issue Jun 10, 2022 · 13 comments

Comments

@UrielCh
Copy link

UrielCh commented Jun 10, 2022

Hi

I have just opened a PR containing a Typescript version of puppeteer-extra

Would a full Typescript PR for this project be accepted?

After spending a full week on my puppeteer-extra fork, fakebrowser look's so easy to work with.

Is there some WIP part of the code that should not be touched?

Can I add some export to fakebrowser to use it as a lib to manage fingerprint data?

@Hoodognik
Copy link

@UrielCh Hello. i trying to use your fork but something went wrong. Maybe you can leave any guide to use your update?

@UrielCh
Copy link
Author

UrielCh commented Jul 20, 2022

send me an error message plz.

the active branch is: heavy-duty

but depend of my fork of pptr-extra, that is being reimplemente on the main project

see:
berstend/puppeteer-extra#646
berstend/puppeteer-extra#649

@UrielCh
Copy link
Author

UrielCh commented Jul 20, 2022

something like that should work:

npm install -g pnpm yarn
git clone https://github.com/UrielCh/puppeteer-extra-ts
cd puppeteer-extra-ts;
npx json -I -f package.json -e 'this.resolutions={}'
yarn install
yarn bootstrap
yarn lerna add --dev puppeteer@14
yarn lerna link
yarn lerna run build --concurrency 1
cd ..
git clone https://github.com/UrielCh/fakebrowser.git -b heavy-duty
cd fakebrowser
pnpm install
pnpm run build

@Hoodognik
Copy link

Hoodognik commented Jul 20, 2022

@UrielCh thank you. I will try and later will comeback with report of result.
actually could be nice have ability install packages just with "yarn add" or "npm install" with automatic build in install process.
I make app used nodegui and want to integrate this. In this case abit difficult to implement that to current project

@UrielCh
Copy link
Author

UrielCh commented Jul 20, 2022

berstend mostly accept my change, but integrating them one by one, will take time.

@kbondnewera
Copy link

Hello @UrielCh i am trying configure with tutorial you posted

npm install -g pnpm yarn
git clone https://github.com/UrielCh/puppeteer-extra-ts
cd puppeteer-extra-ts;
npx json -I -f package.json -e 'this.resolutions={}'
yarn install
yarn bootstrap
yarn lerna add --dev puppeteer@14
yarn lerna link
yarn lerna run build --concurrency 1
cd ..
git clone https://github.com/UrielCh/fakebrowser.git -b heavy-duty
cd fakebrowser
pnpm install
pnpm run build

and getting error

: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

@kbondnewera
Copy link

src/core/FakeBrowser.ts:7:10 - error TS2614: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

7 import { PuppeteerExtra } from 'puppeteer-extra';
~~~~~~~~~~~~~~

src/core/PptrPatcher.ts:9:10 - error TS2614: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

9 import { PuppeteerExtra, PuppeteerExtraPlugin } from 'puppeteer-extra'
~~~~~~~~~~~~~~

src/core/Driver.ts:4:20 - error TS2614: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

4 import { addExtra, PuppeteerExtra, PuppeteerExtraPlugin } from 'puppeteer-extra'
~~~~~~~~~~~~~~

Found 3 errors.

 ELIFECYCLE  Command failed with exit code 1.

@UrielCh
Copy link
Author

UrielCh commented Aug 19, 2022

I used my for of PuppeteerExtra to make it works, that why it do not build out of the box.

@kbondnewera
Copy link

Hello @UrielCh i am very need talk with you, have a email or telegram or contact for i am talk with you.

@kbondnewera
Copy link

i am declared your module and now another error please help me friend setup this i am pay you if need

src/core/FakeBrowser.ts:7:32 - error TS2307: Cannot find module 'puppeteer-extra-ts' or its corresponding type declarations.

7 import { PuppeteerExtra } from 'puppeteer-extra-ts';
~~~~~~~~~~~~~~~~~~~~

@kbondnewera
Copy link

i am running and 352 lies like in the normal version this is correct, please help me friend i am pay you @UrielCh
lies

@UrielCh
Copy link
Author

UrielCh commented Aug 21, 2022

send me a PM in the Discord server, I'm always connected in All-For-Bots as uri.

@Iquaridys
Copy link

src/core/FakeBrowser.ts:7:10 - error TS2614: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

7 import { PuppeteerExtra } from 'puppeteer-extra'; ~~~~~~~~~~~~~~

src/core/PptrPatcher.ts:9:10 - error TS2614: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

9 import { PuppeteerExtra, PuppeteerExtraPlugin } from 'puppeteer-extra' ~~~~~~~~~~~~~~

src/core/Driver.ts:4:20 - error TS2614: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

4 import { addExtra, PuppeteerExtra, PuppeteerExtraPlugin } from 'puppeteer-extra' ~~~~~~~~~~~~~~

Found 3 errors.

 ELIFECYCLE  Command failed with exit code 1.

i got this error too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants