From d9a23cf64bef7b5082c691c994dd5894ad2ed5b6 Mon Sep 17 00:00:00 2001
From: kimson <xpfjrnseks1@naver.com>
Date: Mon, 8 Aug 2022 14:52:31 +0900
Subject: [PATCH] =?UTF-8?q?[BE][:wrench:=20FIX]:=20=EC=BD=94=EB=93=9C=20?=
 =?UTF-8?q?=EC=BB=A8=EB=B2=A4=EC=85=98=20=EA=B4=80=EB=A0=A8=20=EC=88=98?=
 =?UTF-8?q?=EC=A0=95=20[#112=20=EC=B0=B8=EC=A1=B0]?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 build.gradle                                  |  3 +++
 src/main/frontend/src/pages/Home.tsx          |  6 ++---
 .../web/config/SecurityConfiguration.java     | 12 +---------
 .../java/com/narang/web/entity/Comment.java   | 21 ++++++++++++++---
 .../java/com/narang/web/entity/Diary.java     | 22 ++++++++++++++----
 src/main/java/com/narang/web/entity/User.java | 23 +++++++++++++++++--
 .../repository/CommentRepositoryCustom.java   |  2 +-
 .../CommentRepositoryCustomImpl.java          |  4 ++--
 .../web/repository/DiaryRepositoryCustom.java |  2 +-
 .../repository/DiaryRepositoryCustomImpl.java |  4 ++--
 .../repository/EmotionRepositoryCustom.java   |  2 --
 .../EmotionRepositoryCustomImpl.java          |  9 --------
 .../web/repository/UserRepositoryCustom.java  |  3 +++
 .../repository/UserRepositoryCustomImpl.java  | 14 ++++++++---
 .../restController/CommentRestController.java |  3 +--
 .../restController/DiaryRestController.java   |  3 +--
 .../restController/UserRestController.java    |  5 ++--
 .../narang/web/service/CommentService.java    |  4 ++--
 .../com/narang/web/service/DiaryService.java  |  2 +-
 .../narang/web/service/EmotionService.java    |  5 ----
 .../com/narang/web/service/UserService.java   |  4 ++--
 21 files changed, 93 insertions(+), 60 deletions(-)

diff --git a/build.gradle b/build.gradle
index c852fc9..cd30715 100644
--- a/build.gradle
+++ b/build.gradle
@@ -19,6 +19,9 @@ repositories {
 }
 
 dependencies {
+	// https://mvnrepository.com/artifact/com.google.code.findbugs/jsr305
+	implementation 'com.google.code.findbugs:jsr305:3.0.2'
+	// warning error 해결 방안 https://simple-ing.tistory.com/48 참조
 	// https://mvnrepository.com/artifact/org.glassfish.jaxb/jaxb-runtime
 	// java 11 버전 이상은 에러 발생하기 때문에 추가
 	implementation group: 'org.glassfish.jaxb', name: 'jaxb-runtime', version: '4.0.0'
diff --git a/src/main/frontend/src/pages/Home.tsx b/src/main/frontend/src/pages/Home.tsx
index e924c82..cf65938 100644
--- a/src/main/frontend/src/pages/Home.tsx
+++ b/src/main/frontend/src/pages/Home.tsx
@@ -84,7 +84,7 @@ function Home() {
     <Box>
       <DynamicSection
         main
-        title='UPGRADE YOUR DAY'
+        title='당신의 이야기를 들려주세요 😊'
         titleSize='l'
         img='https://cdn.pixabay.com/photo/2020/05/24/11/14/sea-5213746_1280.jpg'
         slot={
@@ -107,7 +107,7 @@ function Home() {
                 )}
               </Typography>
             </Box>
-            {!cookies.token && (
+            {/* {!cookies.token && (
               <Button
                 component={Link}
                 to='/auth/signup'
@@ -117,7 +117,7 @@ function Home() {
                 회원 가입
               </Button>
             )}
-            <Typography variant='body2'>당신의 이야기를 들려주세요.</Typography>
+            <Typography variant='body2'>당신의 이야기를 들려주세요.</Typography> */}
           </Stack>
         }
       />
diff --git a/src/main/java/com/narang/web/config/SecurityConfiguration.java b/src/main/java/com/narang/web/config/SecurityConfiguration.java
index 049ecb8..6a066fc 100644
--- a/src/main/java/com/narang/web/config/SecurityConfiguration.java
+++ b/src/main/java/com/narang/web/config/SecurityConfiguration.java
@@ -16,11 +16,10 @@
 import org.springframework.security.crypto.password.PasswordEncoder;
 import org.springframework.security.web.authentication.UsernamePasswordAuthenticationFilter;
 
-import javax.servlet.Filter;
-
 @Configuration
 @EnableWebSecurity
 @RequiredArgsConstructor
+@SuppressWarnings({"WebSecurityConfigurerAdapter"})
 public class SecurityConfiguration extends WebSecurityConfigurerAdapter {
     @Bean
     public PasswordEncoder encoder() {
@@ -44,15 +43,6 @@ public CustomAuthenticationProcessingFilter customAuthenticationProcessingFilter
     @Override
     public void configure(WebSecurity web) throws Exception {
         web.ignoring().requestMatchers(PathRequest.toStaticResources().atCommonLocations());
-//                .antMatchers("/favicon.ico",
-//                "/api/user/**",
-//                "/api/diaries",
-//                "/api/diary/**",
-//                "/api/likes",
-//                "/api/like/**",
-//                "/api/emotions",
-//                "/api/emotion/**",
-//                "/api/products");
     }
 
     @Override
diff --git a/src/main/java/com/narang/web/entity/Comment.java b/src/main/java/com/narang/web/entity/Comment.java
index 9adb919..ff02545 100644
--- a/src/main/java/com/narang/web/entity/Comment.java
+++ b/src/main/java/com/narang/web/entity/Comment.java
@@ -12,7 +12,9 @@
 import org.springframework.data.mongodb.core.mapping.Field;
 import org.springframework.format.annotation.DateTimeFormat;
 
+import java.util.Arrays;
 import java.util.Date;
+import java.util.List;
 
 @Data
 @AllArgsConstructor
@@ -39,9 +41,22 @@ public class Comment {
     @Field
     private String _class;
 
-    public Comment replace(Comment compare) {
-        this.content = compare.getContent();
-        this.mention = compare.getMention();
+    public Comment replaceIfNotNull(Comment compare) {
+        List<java.lang.reflect.Field> fields = Arrays.asList(this.getClass().getDeclaredFields());
+        fields.forEach(field -> {
+            try {
+                field.setAccessible(true);
+                Object compareField = field.get(compare);
+                Object thisField = field.get(this);
+                if (field.getName() == "userAuth") {
+                    field.set(this, "USER");
+                } else {
+                    field.set(this, compareField != null ? compareField : thisField);
+                }
+            } catch (IllegalAccessException e) {
+                System.out.println("The value is null [" + field.getName() + "]");
+            }
+        });
         return this;
     }
 }
diff --git a/src/main/java/com/narang/web/entity/Diary.java b/src/main/java/com/narang/web/entity/Diary.java
index 8d6dc0b..2e6777a 100644
--- a/src/main/java/com/narang/web/entity/Diary.java
+++ b/src/main/java/com/narang/web/entity/Diary.java
@@ -11,7 +11,9 @@
 import org.springframework.data.mongodb.core.mapping.Field;
 import org.springframework.format.annotation.DateTimeFormat;
 
+import java.util.Arrays;
 import java.util.Date;
+import java.util.List;
 import java.util.stream.Collectors;
 
 @Data
@@ -43,10 +45,22 @@ public class Diary {
     @Field
     private String _class;
 
-    public Diary replace(Diary compare) {
-        this.title = compare.getTitle();
-        this.content = compare.getContent();
-        this.isShare = compare.getIsShare();
+    public Diary replaceIfNotNull(Diary compare) {
+        List<java.lang.reflect.Field> fields = Arrays.asList(this.getClass().getDeclaredFields());
+        fields.forEach(field -> {
+            try {
+                field.setAccessible(true);
+                Object compareField = field.get(compare);
+                Object thisField = field.get(this);
+                if (field.getName() == "userAuth") {
+                    field.set(this, "USER");
+                } else {
+                    field.set(this, compareField != null ? compareField : thisField);
+                }
+            } catch (IllegalAccessException e) {
+                System.out.println("The value is null [" + field.getName() + "]");
+            }
+        });
         return this;
     }
 }
diff --git a/src/main/java/com/narang/web/entity/User.java b/src/main/java/com/narang/web/entity/User.java
index 4617681..3acc15e 100644
--- a/src/main/java/com/narang/web/entity/User.java
+++ b/src/main/java/com/narang/web/entity/User.java
@@ -13,8 +13,9 @@
 import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;
 import org.springframework.security.crypto.password.PasswordEncoder;
 
-import java.util.Collection;
-import java.util.Date;
+import java.util.*;
+import java.util.function.BiConsumer;
+import java.util.stream.Stream;
 
 @Data
 @NoArgsConstructor
@@ -87,4 +88,22 @@ public boolean isEnabled() {
         return true;
     }
 
+    public User replaceIfNotNull(User compare) {
+        List<java.lang.reflect.Field> fields = Arrays.asList(this.getClass().getDeclaredFields());
+        fields.forEach(field -> {
+            try {
+                field.setAccessible(true);
+                Object compareField = field.get(compare);
+                Object thisField = field.get(this);
+                if (field.getName() == "userAuth") {
+                    field.set(this, "USER");
+                } else {
+                    field.set(this, compareField != null ? compareField : thisField);
+                }
+            } catch (IllegalAccessException e) {
+                System.out.println("The value is null [" + field.getName() + "]");
+            }
+        });
+        return this;
+    }
 }
\ No newline at end of file
diff --git a/src/main/java/com/narang/web/repository/CommentRepositoryCustom.java b/src/main/java/com/narang/web/repository/CommentRepositoryCustom.java
index cb9b5ce..3b84236 100644
--- a/src/main/java/com/narang/web/repository/CommentRepositoryCustom.java
+++ b/src/main/java/com/narang/web/repository/CommentRepositoryCustom.java
@@ -7,5 +7,5 @@
 public interface CommentRepositoryCustom {
     public List<Comment> findByDid(String did);
 
-    public Boolean updateToPart(Comment comment);
+    public Boolean update(Comment comment);
 }
diff --git a/src/main/java/com/narang/web/repository/CommentRepositoryCustomImpl.java b/src/main/java/com/narang/web/repository/CommentRepositoryCustomImpl.java
index 5c00c69..2a76e11 100644
--- a/src/main/java/com/narang/web/repository/CommentRepositoryCustomImpl.java
+++ b/src/main/java/com/narang/web/repository/CommentRepositoryCustomImpl.java
@@ -21,9 +21,9 @@ public List<Comment> findByDid(String did) {
     }
 
     @Override
-    public Boolean updateToPart(Comment comment) {
+    public Boolean update(Comment comment) {
         Comment foundComment = commentTemplate.findById(comment.getId(), Comment.class);
-        foundComment.replace(comment);
+        foundComment.replaceIfNotNull(comment);
         commentTemplate.save(foundComment, "comment");
         return true;
     }
diff --git a/src/main/java/com/narang/web/repository/DiaryRepositoryCustom.java b/src/main/java/com/narang/web/repository/DiaryRepositoryCustom.java
index 73a2918..51a33e5 100644
--- a/src/main/java/com/narang/web/repository/DiaryRepositoryCustom.java
+++ b/src/main/java/com/narang/web/repository/DiaryRepositoryCustom.java
@@ -3,5 +3,5 @@
 import com.narang.web.entity.Diary;
 
 public interface DiaryRepositoryCustom {
-    public Boolean updateToPart(Diary diary);
+    public Boolean update(Diary diary);
 }
diff --git a/src/main/java/com/narang/web/repository/DiaryRepositoryCustomImpl.java b/src/main/java/com/narang/web/repository/DiaryRepositoryCustomImpl.java
index 5f8720f..ef8a562 100644
--- a/src/main/java/com/narang/web/repository/DiaryRepositoryCustomImpl.java
+++ b/src/main/java/com/narang/web/repository/DiaryRepositoryCustomImpl.java
@@ -15,9 +15,9 @@ public class DiaryRepositoryCustomImpl implements DiaryRepositoryCustom {
     }
 
     @Override
-    public Boolean updateToPart(Diary diary) {
+    public Boolean update(Diary diary) {
         Diary foundDiary = diaryTemplate.findById(diary.getId(), Diary.class);
-        foundDiary.replace(diary);
+        foundDiary.replaceIfNotNull(diary);
         diaryTemplate.save(foundDiary, "diary");
         return true;
     }
diff --git a/src/main/java/com/narang/web/repository/EmotionRepositoryCustom.java b/src/main/java/com/narang/web/repository/EmotionRepositoryCustom.java
index c8c0724..67933d2 100644
--- a/src/main/java/com/narang/web/repository/EmotionRepositoryCustom.java
+++ b/src/main/java/com/narang/web/repository/EmotionRepositoryCustom.java
@@ -9,8 +9,6 @@ public interface EmotionRepositoryCustom {
 
     public Optional<Emotion> findByDid(String did);
 
-    public Boolean updateToPart(Emotion emotion);
-
     public Boolean deleteByDid(String did);
 
     public Boolean deleteByUid(String uid);
diff --git a/src/main/java/com/narang/web/repository/EmotionRepositoryCustomImpl.java b/src/main/java/com/narang/web/repository/EmotionRepositoryCustomImpl.java
index 9fea266..4cb5f08 100644
--- a/src/main/java/com/narang/web/repository/EmotionRepositoryCustomImpl.java
+++ b/src/main/java/com/narang/web/repository/EmotionRepositoryCustomImpl.java
@@ -34,15 +34,6 @@ public Optional<Emotion> findByDid(String did) {
         return Optional.of(foundEmotion);
     }
 
-    @Override
-    public Boolean updateToPart(Emotion emotion) {
-        Criteria cr = new Criteria("did").is(emotion.getDid());
-        Query q = new Query(cr);
-        emotionTemplate.remove(q, "emotion");
-        emotionTemplate.insert(emotion, "emotion");
-        return true;
-    }
-
     @Override
     public Boolean deleteByDid(String did) {
         Criteria cr = new Criteria("did").is(did);
diff --git a/src/main/java/com/narang/web/repository/UserRepositoryCustom.java b/src/main/java/com/narang/web/repository/UserRepositoryCustom.java
index 4425407..62a78aa 100644
--- a/src/main/java/com/narang/web/repository/UserRepositoryCustom.java
+++ b/src/main/java/com/narang/web/repository/UserRepositoryCustom.java
@@ -1,5 +1,6 @@
 package com.narang.web.repository;
 
+import com.narang.web.entity.Comment;
 import com.narang.web.entity.User;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.data.mongodb.core.MongoTemplate;
@@ -10,4 +11,6 @@ public interface UserRepositoryCustom {
     public Optional<User> findByNickName(String nickName);
 
     public Optional<User> findByEmail(String email);
+
+    public Boolean update(User user);
 }
diff --git a/src/main/java/com/narang/web/repository/UserRepositoryCustomImpl.java b/src/main/java/com/narang/web/repository/UserRepositoryCustomImpl.java
index e82bdbd..c632df6 100644
--- a/src/main/java/com/narang/web/repository/UserRepositoryCustomImpl.java
+++ b/src/main/java/com/narang/web/repository/UserRepositoryCustomImpl.java
@@ -1,5 +1,6 @@
 package com.narang.web.repository;
 
+import com.narang.web.entity.Comment;
 import com.narang.web.entity.User;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.data.mongodb.core.MongoTemplate;
@@ -11,14 +12,14 @@
 
 public class UserRepositoryCustomImpl implements UserRepositoryCustom {
     @Autowired
-    MongoTemplate mongo;
+    MongoTemplate userTemplate;
 
     @Override
     public Optional<User> findByNickName(String nickName) {
         Criteria cr = new Criteria("nickName");
         cr.is(nickName);
         Query q = new Query(cr);
-        return Optional.of(mongo.findOne(q, User.class));
+        return Optional.of(userTemplate.findOne(q, User.class));
     }
 
     @Override
@@ -27,6 +28,13 @@ public Optional<User> findByEmail(String email) {
         cr.is(email);
         Query q = new Query(cr);
 
-        return Optional.of(mongo.findOne(q, User.class));
+        return Optional.of(userTemplate.findOne(q, User.class));
+    }
+
+    public Boolean update(User user) {
+        User foundUser = userTemplate.findById(user.getId(), User.class);
+        foundUser.replaceIfNotNull(user);
+        userTemplate.save(foundUser, "user");
+        return true;
     }
 }
diff --git a/src/main/java/com/narang/web/restController/CommentRestController.java b/src/main/java/com/narang/web/restController/CommentRestController.java
index 879b069..9d32e47 100644
--- a/src/main/java/com/narang/web/restController/CommentRestController.java
+++ b/src/main/java/com/narang/web/restController/CommentRestController.java
@@ -41,8 +41,7 @@ public String insert(Comment comment) {
 
     @PutMapping("/comment")
     public Boolean update(Comment comment) {
-        commentService.updateToPart(comment);
-        return true;
+        return commentService.update(comment);
     }
 
     @DeleteMapping("/comment/{id}")
diff --git a/src/main/java/com/narang/web/restController/DiaryRestController.java b/src/main/java/com/narang/web/restController/DiaryRestController.java
index 1ff96a8..1a49564 100644
--- a/src/main/java/com/narang/web/restController/DiaryRestController.java
+++ b/src/main/java/com/narang/web/restController/DiaryRestController.java
@@ -34,8 +34,7 @@ public String insert(Diary diary) {
 
     @PutMapping("/diary")
     public Boolean update(Diary diary) {
-        diaryService.update(diary);
-        return true;
+        return diaryService.update(diary);
     }
 
     @DeleteMapping("/diary/{id}")
diff --git a/src/main/java/com/narang/web/restController/UserRestController.java b/src/main/java/com/narang/web/restController/UserRestController.java
index 0631668..63b750d 100644
--- a/src/main/java/com/narang/web/restController/UserRestController.java
+++ b/src/main/java/com/narang/web/restController/UserRestController.java
@@ -38,7 +38,7 @@ public String findAll() throws JsonProcessingException {
     @GetMapping("/user/{id}")
     public String findById(@PathVariable("id") String id) throws JsonProcessingException {
         System.out.println(id);
-        System.out.println(userService.findById(id));
+        User foundUser = userService.findById(id);
         return mapper(userService.findById(id));
     }
 
@@ -105,8 +105,7 @@ public Map<String, Object> fileupload(MultipartFile multipartFile, String id, St
 
     @PutMapping("/user")
     public Boolean update(User user) {
-        userService.update(user);
-        return true;
+        return userService.update(user);
     }
 
     @DeleteMapping("/user/{id}")
diff --git a/src/main/java/com/narang/web/service/CommentService.java b/src/main/java/com/narang/web/service/CommentService.java
index 2d97b35..8b12c24 100644
--- a/src/main/java/com/narang/web/service/CommentService.java
+++ b/src/main/java/com/narang/web/service/CommentService.java
@@ -33,8 +33,8 @@ public String insert(Comment comment) {
         return newComment.getId();
     }
 
-    public Boolean updateToPart(Comment comment) {
-        return commentRepository.updateToPart(comment);
+    public Boolean update(Comment comment) {
+        return commentRepository.update(comment);
     }
 
     public Boolean deleteById(String id) {
diff --git a/src/main/java/com/narang/web/service/DiaryService.java b/src/main/java/com/narang/web/service/DiaryService.java
index 7cf29a7..5442484 100644
--- a/src/main/java/com/narang/web/service/DiaryService.java
+++ b/src/main/java/com/narang/web/service/DiaryService.java
@@ -30,7 +30,7 @@ public String insert(Diary diary) {
     }
 
     public Boolean update(Diary diary){
-        return diaryRepository.updateToPart(diary);
+        return diaryRepository.update(diary);
     }
 
     public Boolean deleteById(String id) {
diff --git a/src/main/java/com/narang/web/service/EmotionService.java b/src/main/java/com/narang/web/service/EmotionService.java
index d21cb83..002ca67 100644
--- a/src/main/java/com/narang/web/service/EmotionService.java
+++ b/src/main/java/com/narang/web/service/EmotionService.java
@@ -35,11 +35,6 @@ public String insert(Emotion emotion) {
         return newEmotion.getId();
     }
 
-    public Boolean update(Emotion emotion) {
-        emotionRepository.updateToPart(emotion);
-        return true;
-    }
-
     public Boolean delete(String id){
         emotionRepository.deleteById(id);
         return true;
diff --git a/src/main/java/com/narang/web/service/UserService.java b/src/main/java/com/narang/web/service/UserService.java
index ea5c2bc..f2266dd 100644
--- a/src/main/java/com/narang/web/service/UserService.java
+++ b/src/main/java/com/narang/web/service/UserService.java
@@ -117,8 +117,8 @@ public Boolean checkPassword(String password, String id) {
         }
     }
 
-    public User update(User user) {
-        return userRepository.save(user);
+    public Boolean update(User user) {
+        return userRepository.update(user);
     }
 
     public Boolean deleteById(String id) {