Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading release APK in Github release instead of standalone APK. #4115

Closed
wants to merge 2 commits into from

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Nov 28, 2024

Fixes #4114

  • To resolve the publishing issue on IzzyOnDroid, we are now uploading the Release APK(with org.kiwix.kiwixmobile package name) to the GitHub release, so that IzzyOnDroid can retrieve the APK and upload it to their platform easily.
  • Generated dummy release APKs along with the dummy bundle to have them readily available if needed. For example, in the current scenario, we need to manually generate the release APKs and upload them to the 3.12.0 GitHub release so that IzzyOnDroid can fetch and update the application on their platform. See it is uploaded the Release APKs https://github.com/kiwix/kiwix-android/actions/runs/12063880435

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft November 28, 2024 06:13
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.71%. Comparing base (116180e) to head (f1047bc).
Report is 64 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4115      +/-   ##
============================================
- Coverage     58.74%   58.71%   -0.03%     
+ Complexity     1564     1562       -2     
============================================
  Files           316      316              
  Lines         13445    13445              
  Branches       1708     1708              
============================================
- Hits           7898     7894       -4     
- Misses         4413     4414       +1     
- Partials       1134     1137       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review November 28, 2024 08:57
* To resolve the publishing issue on `IzzyOnDroid`, we are now uploading the `Release` APK(with `org.kiwix.kiwixmobile` package name) to the GitHub release, allowing `IzzyOnDroid` to easily retrieve the APK and upload it to their platform.
… readily available if needed.

* For example, in the current scenario, we need to manually generate the release APKs and upload them to the 3.12.0 GitHub release so that IzzyOnDroid can fetch and update the application on their platform.
@MohitMaliFtechiz MohitMaliFtechiz added this to the 3.13.0 milestone Dec 18, 2024
@kelson42 kelson42 modified the milestones: 3.13.0, 3.14.0 Dec 18, 2024
@kelson42
Copy link
Collaborator

Closing because #4114 (comment)

@kelson42 kelson42 closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants