Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-fileuploader no longer a webircgateway plugin? #100

Open
vdachev opened this issue May 8, 2024 · 2 comments
Open

plugin-fileuploader no longer a webircgateway plugin? #100

vdachev opened this issue May 8, 2024 · 2 comments

Comments

@vdachev
Copy link

vdachev commented May 8, 2024

Hello,

It seems that 8433ed2 from PR #95 seems to have just dropped the support for "plugin-fileuploader" to run as a "webircgateway" plugin, although it just states the cryptic "Upgrade tusd to v1.9.1". The "webircgateway-plugin" directory has just disappeared. And, honstely, that's a pity.

Moreover, the documentation does not seem to reflect the change so it's misleading.

@ItsOnlyBinary
Copy link
Contributor

due to the issues with building and maintaining as a webircgateway plugin, I did not think anyone would be using it that way so i dropped the file for using it that way, although it should still work.

tusd is the main library used to handle the file upload and pr95 does include many improvements to the fileuploader modification of that library.

I may consider returning the plugin file in the future as it does no real harm being there.

@vdachev
Copy link
Author

vdachev commented May 9, 2024

Thank you for the extremely prompt response. Deploying the file uploader server as a webircgateway pluging comes in handy because it saves the need for depoying a dedicated service for this particular functionality.

My other concern is that the README.md file doesn't seem to reflect the change, so it took some time to realize that this is no longer an option.

P.S. Meanwhile, I noticed that the service deployed at https://uploads.kiwiirc.com/files/ returns 522 Connection timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants