-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculations Testing #9
Comments
I've posted to Barr report, ukaps and planted tank requesting volunteers for beta testing. |
Hey guys, I found something missing in the latest version: http://rotalabutterfly.com/test/ If you want to find a solution of CSM+B which exceed the solubility of the compound, you don't get ay warning. Whereas my PHP backend is returning the "sol_error" flag, I can't see that shown in the new JS implementation. Jennifer, thoughts? Here is what I tried: 75gl tank, DIY, CSM+B, a solution, 500ml container, 5ml dose (too little for solubility) |
I will post comments as i receive them from testers. "I tested for KNO3 for EI dosing a DIY solution. However, the result only told me how many grams of dry ferts to add to my aquarium. What I expected from the old version is that it should tell me how many grams/teaspoons to add to the water in the dosing container" |
"Can we change the contact link to contact & feedback" |
"I just tested the Test page and no output is provided for the concentrations." |
Two comments now mentioned grams/teaspoons not just grams |
Yes Jason, I get the same results, and they should be correct. What I meant is that solubility for that dosing (5ml) would have some issues, and the calculator should warn that. The PHP backend passes the variable "sol_error" set to 1 in case solubility issues are reached. I think the UI is just not handling that passed parameter. Does this make sense? |
I can add that calculation to the PHP backend, and return the conversion in tsp or tbsp as an additional variable. |
I'd like to steer away from this - its overlong for a navigation link. What we could do instead is display a note below the calculator that says something along the lines of "This is an evolving project that is currently in beta, your feedback is appreciated, please use our [link]contact form[/link]. We could display the same/a similar message on the contact page itself. Acceptable solution? |
Sounds good to me Jennifer :) |
"Also labeling urea as toxic is misleading. It's only toxic at a certain concentration like all of the elements." |
Fab it makes sense now and sounds like a good idea to warn about this |
Would be nice to be able to choose the target element when calculating for "dose to reach target". For instance, if I wanted to raise dGH by ??? edit: After the calculator is up and running, if you wanted to get really tricky, you could do something like. |
Some more feedback from testers... So, some general feedback/wishlist here after tinkering with it for a bit, some of which is inherited from Wet's original calculator... Thus far looks like a good start. Issues specific to the test calculator, most of which is probably due to the beta nature and may already be well known to you:
Wishlist things that were issues in Wet's calculator:
|
I'll make sure I take care of this when I begin working on error messages/form validation, etc. I created an Issue so I won't forget. |
Thanks :), one comment that keeps popping up is the toxicity warnings |
I'm working on the language selection right now, I'll do the error flags and toxicity warnings next. |
Nice :D Do we have any Italians that can test this? ;) |
We're going to need all the languages tested - Because the form labels on our calculator are slightly different than Wet's original I had to adjust the translations - I used Google translate to do so and they will definitely need double checking. I will put a note on the interface asking for help with this. |
I am Italian guys! What do you want me to test? |
Jason, I think we can do pretty much everything you have described above... step-by-step we can do it! Jennifer: just let me know when you need me to step-in. Thanks :) |
That was taken from original Wet's implementation. We can change whatever we like. As you already said, this is a good start, but we can shape it as we like. |
Hey Fab I know you are Italian hence my wink smile :) It's all sounding great and the future addons are endless. Thankyou both :D |
Sorry, I missed that!! ;) Just woke up, still sleepy! :) |
Please be as specific as possible when reporting Calculations errors. It is most helpful for us if you list the following:
Thank you :)
The text was updated successfully, but these errors were encountered: