Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language selection #8

Open
kisanjong opened this issue Jul 22, 2015 · 12 comments
Open

Language selection #8

kisanjong opened this issue Jul 22, 2015 · 12 comments
Assignees

Comments

@kisanjong
Copy link
Owner

i18n language selection

Multilingual feature

@ravenwilde ravenwilde self-assigned this Jul 22, 2015
@ravenwilde
Copy link
Contributor

Question for you both:

I have the english language file converted over to a json file and I will probably convert the others over as well. Are you guys okay with this? I don't think they're being used by main.php is that correct @fablau ?

@fablau
Copy link
Collaborator

fablau commented Jul 24, 2015

I have the english language file converted over to a json file and I will probably convert the others over as well. Are you guys okay with this? I don't think they're being used by main.php is that correct @fablau ?

Yes, that's correct. Backend crunches just numbers for now :)

@kisanjong
Copy link
Owner Author

The drop down selection is showing strange characters unlike the actual calculator that looks fine to me anyway.

screenshot_2015-08-02-07-00-23

@kisanjong
Copy link
Owner Author

Just to check this is not a server related related problem?

@ravenwilde
Copy link
Contributor

I'm not sure, it's doing the same thing to me on my local. I need to do some research and figure out what the problem is. I should be back to work on this project tomorrow.

@kisanjong
Copy link
Owner Author

I've had a few users ask if we can change the whole site including header menu etc to the selected language.

Thanks

@diogorolo
Copy link
Contributor

I deleted my previous comment because it was inaccurate.
I can fix this in my local by simply adding, in the head, the following:

<meta charset="UTF-8">

@kisanjong
Copy link
Owner Author

As easy as that ;) thanks @diogorolo its working perfect now,

I also added it to wets old calc at yanc.rotalabutterfly.com fixing the same problem on that one :)

@kisanjong
Copy link
Owner Author

Added to http://rotalabutterfly.com

screenshot_2015-08-25-12-08-25

@diogorolo
Copy link
Contributor

The translations in json/ptbr.json are still wrong though.
https://github.com/kisanjong/rotalabutterfly/blob/b9658ee41fe9ceeb35da444e29939b81d268aa9a/json/ptbr.json#L6,L7

@kisanjong
Copy link
Owner Author

The translations are all taken from wets calculator, please feel free to update any mistakes :)

Once the main calculator is complete, i will work on the languages.

Thanks

@ravenwilde
Copy link
Contributor

@diogorolo Thanks for solving the menu issue - also, do feel free to update the json/ptbr.json file - I had to make adjustments to Wet's original translations to fit with our new labels and used Google Translate to do so. I'm sure there are tons of errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants