General Development Talk

[ravenwilde]

This thread is reserved for discussion between developers regarding code hand-offs etc.

Any bugs, new features, or calculation errors should be put into individual tickets.

[ravenwilde]

@fablau - carrying this discussion over from the old thread:

How do we want to handle messages - do you want to compile them with the appropriate embedded variables server side? Or would you like me to try and handle it in the javascript?

[ravenwilde]

@fablau PS. I've set the 'Round to...' select dropdown to default to 2.

[fablau]

Great to be on this new thread!

How do we want to handle messages - do you want to compile them with the appropriate embedded variables server side? Or would you like me to try and handle it in the javascript?

Either way, as you prefer. For me is pretty simple, but if you have already something in place, and you like to do it in JS, please, go ahead. Let me know, it's your call! :)

[kisanjong]

Ui ver 1.1 now on test server and looking great :)

[ravenwilde]

@fablau - I had an 'aha!' moment last night and realized that I could handle the output message variable interpolation with a string replace function. So I'll take care of this on my end.

[ravenwilde]

I've opened a 'Calculation Testing' Issue that you (Jason) can link to on the forums if you want to enlist people as testers. I figure its probably easier (for them) if we have them report any problems they find in that one thread rather than have them open new issues.

Also, please chime in on that thread if I forgot to list something else that they should report.

[fablau]

PS. I've set the 'Round to...' select dropdown to default to 2.

I forgot this... great, thank you Jen!

[fablau]

I had an 'aha!' moment last night and realized that I could handle the output message variable interpolation with a string replace function. So I'll take care of this on my end.

Fantastic!

[fablau]

Ui ver 1.1 now on test server and looking great :)

Yes, working great indeed. Great job Jennifer!

[kisanjong]

Links posted on the Barr report and I'll speak to a few people asap for beta testers.

[kisanjong]

Should we open an issue for the high charts feature that was used in wets calculator?

http://www.highcharts.com/demo

[ravenwilde]

Yes. I will do that. I'm still trying to figure out how he was generating that range chart - I'm not entirely sure that highcharts was used for that.

[kisanjong]

I'm not positive it was high charts but its mentioned in his readme file at Flores.

[ravenwilde]

I think he was using highcharts for the longterm modeling but the range chart may have been homegrown.... I've been looking through the code, but its ruby, so its taking a while ;)

[fablau]

I think he was using highcharts for the longterm modeling but the range chart may have been homegrown.... I've been looking through the code, but its ruby, so its taking a while ;)

Jennifer, I think the code controlling the chart is at the bottom of the original nutes.rb (from line 301, "fancy graphs"). I left that part of the code out from my translation to PHP.

[fablau]

Links posted on the Barr report and I'll speak to a few people asap for beta testers.

Great, thank you Jason!

[ravenwilde]

Jennifer, I think the code controlling the chart at the bottom of the original nutes.rb (from line 301). I left that code out from my translation to PHP.

Yeah, that's what I've been looking at - I think you may have to generate some of the vars and pass them off to me.

[fablau]

Yes, I think I can do that pretty easily. Looks like he was handling template place-holders directly there. I could translate those into simple vars, and then give them back to you in the AJAX response... thoughts?

[fablau]

The only issue could be with loops... we could end up having a lot of variables, and I don't think that would be the right way to do it. That should be done via JS, maybe having the starting and ending points only? I'll think a little bit more about this.

[ravenwilde]

Let me look at the code more in depth and I'll have a more cogent response for you later tonight.

[fablau]

Let me look at the code more in depth and I'll have a more cogent response for you later tonight.

OK!

[kisanjong]

Some one mentioned multiple selection for example the whole ei..

They can select trace +n +p +k and get results as a Printable list for all?

[fablau]

Some one mentioned multiple selection for example the whole ei..
They can select trace +n +p +k and get results as a Printable list for all?

That could be done easily UI input side, but the whole work would be JS side, therefore Jennifer's... she should re-iterate more calls to the PHP backend for each requested compound, then build the output list. Maybe keep this as a future feature?

[ravenwilde]

Maybe keep this as a future feature?

Yeah... this is something we could do later on. For now I'd like to focus on replicating the features of wet's calculator. Once we get all of those taken care of then we can look at building out something like this.

[kisanjong]

I totally agree Jennifer that new features will come after.

[kisanjong]

Hello both :) how things going? :)

[kisanjong]

Looking good Jennifer :) @fablau will need to confirm the language is correct but from what I can see its working fine on the ui just the results are still English.

[fablau]

Looking good Jennifer :) @fablau will need to confirm the language is correct but from what I can see its working fine on the ui just the results are still English.

Jason, do you want me to look at the Italian template file? Please, let me know. Thanks.

[ravenwilde]

Hi guys - I've in the middle of transitioning to a new job (Yaaaay!) so I had to put this on hold for a bit. I'm also moving all my work over to a different computer so I need to set my dev environment up again. I've got it mostly there but I need to do that whole, PEAR, PECL, YAML thing again. I'll probably be back on track and working on this again by early next week.

@fablau - If you want to start work on the Italian language file you should look at the one that I pushed along with the UI branch - its located here: https://github.com/kisanjong/rotalabutterfly/blob/ui/json/it.json
I had to change it from the original a bit to work better with our current UI... and I used Google Translate, so I am 100% certain that it needs improving. :)

[kisanjong]

Yes please Fab as Jennifer said :)

[ravenwilde]

You too! This wouldn't have happened with out you!

[kisanjong]

Thanks :)

current ui is now available at http://rotalabutterfly.com/test/

[fablau]

Thank you for allowing me to be part of this project! Great work guys!

[kisanjong]

Hi Fab & Jen

After numerous requests can we start on the results of my dose part of the calculator?

Including the graphical display.

Thanks
Jason

[fablau]

Hi Jason, sorry for my late reply.

The back-end should already work for that... am I correct Jennifer?

[ravenwilde]

@fablau - as far as I can tell this isn't working - all the results that come back when I try to get the result of a dose are zero or null.

EDIT: I'm also not sure that Target is is working either.

[fablau]

Hi Jen. The "Dose to reach a target" seems to return some results... we'll need to check if they are correct though.

The "Result of my dose" doesn't return anything, you are right. I'll look into that asap.

@kisanjong - I can't find the URL to the old-working calculator, could you please remind me? I'd need to compare results if possible.

Thanks!

[kisanjong]

Hi Fab link is in the header of the new calculator ;)

WET'S OLD CALCULATOR
http://yanc.rotalabutterfly.com/

[fablau]

Ouch!! Sorry missed that!!

Thank you very much, I will look into everything ASAP.
Thanks!

Fabrizio

On Sep 13, 2015, at 08:43, Jason [email protected] wrote:

Hi Fab link is in the header of the new calculator ;)

WET'S OLD CALCULATOR
http://yanc.rotalabutterfly.com/

—
Reply to this email directly or view it on GitHub.

[kisanjong]

Hehe no problem :)

And thanks

[fablau]

Thanks Jason… found what the problem is, I’ll get back to Jennifer asap.

Thanks!

Fab.

On Sep 13, 2015, at 11:24 AM, Jason [email protected] wrote:

Hehe no problem :)

And thanks

—
Reply to this email directly or view it on GitHub #7 (comment).

[fablau]

Ok. Jennifer, looks like the problem are the variables passed to the back-end. They should be the same sent from the old system.

For example, if you select the following values:

Tank size: 10 US gallons
Method: DIY
Nutrient: K2HPO4
Using: Dry Dosing
I am Calculating For: Result of my Dose
I am adding: 50 ml (it should be mg though!)

And then hit calculate, here is what the new calculator UI is passing to the backend:

---

calc_for: result
compound: K2HPO4
dose_amount: 50
dose_units: milliliter
method: dry
round_to: 2
source: diy
tank_units: gal
tank_vol: 10

---

Whereas, the old calculator is passing the following values instead:

---

calc_for: dump <--- This is the correct value
compound: K2HPO4
dose_amount: 50
dose_units: mg <--- This is the correct value
method: dry
round_to: 2
source: diy
tank_units: gal
tank_vol: 10

---

Please, let me know if by changing the values as above makes the trick. Thanks.

[ravenwilde]

Ahhhh... okay, I'll fix that problem tonight or tomorrow and push a fix for you.

[fablau]

Sounds good! Thank you Jen :)

On Sep 14, 2015, at 4:12 PM, Jennifer Scroggins [email protected] wrote:

Ahhhh... okay, I'll fix that problem tonight or tomorrow and push a fix for you.

—
Reply to this email directly or view it on GitHub #7 (comment).

[ravenwilde]

Question though, on your end can you change 'dump' to 'result'? Dump just doesn't make sense semantically and that kind of bothers me :)

[fablau]

Just done Jen. Let me know if it works.

[kisanjong]

Hello Fab & Jen how's its going?

@ravenwilde what's the next stage your planing?

Thanns

[fablau]

Hi Jason. I was waiting for Jennifer to tell me if the backend is now working correctly for the "Result of my dose". What else do I need to take care of? I lost some track here... thanks for reminding me!

[kisanjong]

Hi Fab

No worries been busy myself :)

I think that's the next stage, once that's confirmed its onto the result of my dose then a few beta checks from guys on the forum and then onto the other features?

Thanks

[fablau]

I am ok with that Jason! Let's wait for Jennifer. Thanks!

[kisanjong]

Hello,

Burr_740 has just posted in the General Discussion forum of rotalabutterfly.com Forums under the title of Getting very different results between old and new calc....

This thread is located at http://rotalabutterfly.com/forum/showthread.php/12-Getting-very-different-results-between-old-and-new-calc

Here is the message that has just been posted:

---

Hi guys, thanks a lot for your work on this.

You may already be aware, but Im also getting a difference between the old and the new for csm-b.

 Calculating for 65 gal, EI, dry dose: Old says 1 gram, new says 1.88.

Just thought you may need to know. Thanks again

---

[fablau]

Hi Jason. Yes, I see the difference... that's weird... I'll look into that as soon as possible.

[fablau]

Ok, I need to look into this in depth, but I think the problem could be that the old calculator rounds results, whereas our new one is more precise (2 decimal points). I'll confirm this as soon as I can look at the code, I am currently out town.

[ravenwilde]

Hi guys, sorry, I've been busy with work and family stuff. I'm going to make a concerted effort to work on this this week - I will be in touch.

[kisanjong]

Thanks Both :)

[fablau]

Glad to see you here Jen! Jason: you are welcome.

I have looked into the rounding issue above, and I can confirm that our new calculator shows more precise results according to the decimal digits defined in the calculator form, whereas Wet's calculator ignored that in some way (!!!) and rounded everything to the integer despite shows 0 as decimal digit (i.e. 1.0 instead of 1.88, or 3.0 instead of 3.01, etc)

[fablau]

Jason, Jennifer, yesterday I used our new calculator for my own tank needs, and we would need to change the output when the user select "a solution" as a result compared to "dry dosing". The output may be confusing to the user, it tells to add a certain amount "to your tank" instead than to "a container" of the defined volume.

[kisanjong]

@ravenwilde how are things? where are you ;)

[ravenwilde]

@kisanjong I've been working on overhauling part of the interface so we can print out charts. I don't have anything to push yet because its all in pieces. I actually have time this weekend to devote to this project so I will get back to you then.

[kisanjong]

Hi Jen, that's great news, I'm looking forward to the charts, thanks