New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to implement a proper pImpl #1

Open

mkirchner opened this issue Feb 24, 2012 · 0 comments

Assignees

Member

mkirchner commented Feb 24, 2012

The current implementation uses only "half a pImpl".
The Mercury.hpp header includes MercuryImpl.hpp and that does not make much sense.

Solution: move MercuryImpl to Mercury::Impl and declare

...
private:
    struct Impl;
    shared_ptr pImpl_;

ghost assigned mkirchner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment