Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in merge_replicates_barcode_counts.py when BC threshold too high #139

Open
pi-zz-a opened this issue Nov 19, 2024 · 1 comment
Open

Comments

@pi-zz-a
Copy link
Contributor

pi-zz-a commented Nov 19, 2024

I set the BC threshold to minimum 10, which appeared to be too high for my dataset. An empty dataframe was returned after filtering, which in turn results in a missing key error for the keys "dna_count_1" "rna_count_1" etc.
To make this more intuitive, either an error returning an explanation, or creating an empty filtered file, or both, would be good.

@visze
Copy link
Collaborator

visze commented Nov 25, 2024

It seems to be that # order columns to have dna then rna count of each replicate expects a certain number of columns but

df = df.pivot_table(

does not create them.

So the script is buggy. Possible solutions are:

  1. check input files and throw exception when one of them is empty
  2. pivot tables and add headers if they do not exist. then order them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants