Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable room order on rooms page #332

Open
OmTheTurtle opened this issue Jun 23, 2020 · 2 comments
Open

Customizable room order on rooms page #332

OmTheTurtle opened this issue Jun 23, 2020 · 2 comments
Labels
enhancement New feature or request low priority No hurry, this can wait.

Comments

@OmTheTurtle
Copy link
Member

For students living on higher floors, the relevant ones are currently at the bottom of the page. We can add an option to the user in the database whether they want to see the rooms in ascending or descending order (could be set on the user's profile page).

@OmTheTurtle OmTheTurtle added enhancement New feature or request low priority No hurry, this can wait. labels Jun 23, 2020
@triszt4n
Copy link
Member

Was thinking about drag-and-drop-like/swappable implementation of the the items, but that might be a serious work to do with bulma.

So a rather convenient solution would be favouriting ⭐ the floors, so they appear on top.

My question: should we save the favourites into the database, or do we just simply save the favourites in localStorage (so in the browser)?

@OmTheTurtle
Copy link
Member Author

Although the drag-drop feature could be achieved with e.g. dragula, I think it's way too minor for that. And potentially can start an avalanche of feature-creeping, where at the end we would decide to move to a separate forntend 😄

I like the 'mark as favorite' approach. I'd vote for a persistent store, since I think people would use the site from their mobile too pretty often, and it would be good to keep everything in sync and consistent.

@triszt4n triszt4n assigned triszt4n and unassigned triszt4n Jul 5, 2020
nmate980829 added a commit that referenced this issue Sep 2, 2020
nmate980829 added a commit that referenced this issue Sep 7, 2020
@triszt4n triszt4n linked a pull request Sep 8, 2020 that will close this issue
nmate980829 added a commit that referenced this issue Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority No hurry, this can wait.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants