Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions in all services #30

Open
balintking opened this issue Aug 28, 2024 · 0 comments
Open

Fix exceptions in all services #30

balintking opened this issue Aug 28, 2024 · 0 comments
Labels
backend Backend development invalid This doesn't seem right

Comments

@balintking
Copy link
Collaborator

Quick fix: Now, every method throws a NotFoundException in all methods in the services. What we really want is to throw a 404 only when an object is really missing. In other situations (e.g. when connecting to db fails) getting not found could be misleading, therefore we should throw the corresponding exception or we wouldn't even need exception handling.

@balintking balintking added invalid This doesn't seem right backend Backend development labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend development invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant