Implement kiota_serialization_text
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoboss
force-pushed
the
issues/21-text-serialization
branch
from
db1ae70 to
f6331f7
Compare
andrueastman
approved these changes
Apr 8, 2024
ricardoboss
force-pushed
the
issues/21-text-serialization
branch
from
f6331f7 to
6b83704
Compare
|
Just rebased (no conflicts); continuing with merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
Enum deserialisation is currently not possible, because Dart doesn't have reflection. I linked to an issue that proposes to add abstract static members to classes, which would in turn allow the Dart SDK to provide static access to the
valuesmember of enums which would allow us to use it to deserialise a specific value.In the meantime we either don't support enum deserialisation (not preferred) or we implement a workaround which would increase the amount of generated code (via static factories that register each available enum).