Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed path dependencies to use pub.dev and API compatible version ranges #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ricardoboss
Copy link
Member

Also updated some (dev) dependencies that where not aligned with the other packages.

Fixes #54

@baywet
Copy link
Collaborator

baywet commented Dec 6, 2024

@ricardoboss the CI is failing, would you mind having a look when you have a minute please?

@ricardoboss
Copy link
Member Author

@baywet the CI failing is expected since the packages now depend on the version that is available on pub.dev. Since we haven't published any packages yet, the CI cannot get them.

This should be resolved once we publish the first version.

@baywet
Copy link
Collaborator

baywet commented Dec 6, 2024

Thank you for the additional information.

Is there no way to setup a fallback? I'm worried about a few things:

  • depending on how much time we take for the initial publish, it might mask broken additional changes.
  • contributors will have to change those back when working on changes across multiple projects.
  • publishing might initially fail because of the lack of a specific version, also the workflow will have to publish in the order of the dependency tree.

@ricardoboss
Copy link
Member Author

ricardoboss commented Dec 6, 2024

AFAIK there is no kind of fallback behaviour for pub dependencies. I have an idea how to work around this though:

  1. replace all dependencies with git dependencies (i.e. cherry pick this commit: c1465a6)
  2. replace all those dependencies with a specific version when publishing

This would allow us to ensure compatibility with the main branch while developing PRs but also requires more attention when publishing versions (pub.dev doesn't allow path or git dependencies in published packages).

@ricardoboss
Copy link
Member Author

We could also temporarily use dependency_overrides to change the dependencies to path/git until the first version is published https://dart.dev/tools/pub/dependencies#dependency-overrides

@baywet
Copy link
Collaborator

baywet commented Dec 6, 2024

Thank you for the additional information.

After thinking about this more, I believe we should leave the versions in. One of the rationales being: release please won't be able to orchestrate versions if we leave local or git references in the code.

As for dependencies override, I think it'd be a great thing to document in a development.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change all relative dependencies to use pub.dev (as opposed to path or git dependencies)
2 participants