-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed path dependencies to use pub.dev and API compatible version ranges #55
base: main
Are you sure you want to change the base?
Conversation
…anges Also updated some dev dependencies
@ricardoboss the CI is failing, would you mind having a look when you have a minute please? |
@baywet the CI failing is expected since the packages now depend on the version that is available on pub.dev. Since we haven't published any packages yet, the CI cannot get them. This should be resolved once we publish the first version. |
Thank you for the additional information. Is there no way to setup a fallback? I'm worried about a few things:
|
AFAIK there is no kind of fallback behaviour for pub dependencies. I have an idea how to work around this though:
This would allow us to ensure compatibility with the |
We could also temporarily use |
Thank you for the additional information. After thinking about this more, I believe we should leave the versions in. One of the rationales being: release please won't be able to orchestrate versions if we leave local or git references in the code. As for dependencies override, I think it'd be a great thing to document in a development.md |
Also updated some (dev) dependencies that where not aligned with the other packages.
Fixes #54