Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craft 4 compatibility? #13

Open
karljennings opened this issue Jun 3, 2022 · 19 comments
Open

Craft 4 compatibility? #13

karljennings opened this issue Jun 3, 2022 · 19 comments

Comments

@karljennings
Copy link

Just wondering if there is any plan to update for Craft 4?

@kinoli
Copy link
Owner

kinoli commented Jun 3, 2022

Not at the present.

@chadcrowell
Copy link
Contributor

@kinoli Do you mind if I fork and release for C4 then?

@kinoli
Copy link
Owner

kinoli commented Jul 11, 2022

sure thing.

@chadcrowell
Copy link
Contributor

Just released Groupie for Craft 4. Thanks Jesse for this great little plugin.

@chadcrowell
Copy link
Contributor

Btw Jessie do you want to continue to maintain the C3 version? If not, assign this repo over to me and I'll maintain both the C3 and C4 versions. Otherwise I'll need to rename my C4 version so it can go into the plugin store.

@kinoli
Copy link
Owner

kinoli commented Aug 23, 2022

I'm fine maintaining the C3 version.

@chadcrowell
Copy link
Contributor

Hey again, plugin got rejected by P&T - sounds like the options (straight from Brandon) are:

  1. You give ownership of the current plugin to me, and I release the C4 updates in the current repo.
  2. I rename the C4 version of Groupie to something completely different and release it. There can't be your Groupie for C3 and mine for C4, that doesn't work. If I rename it and release it, they will mark your Groupie as abandoned and list mine as the recommended replacement for C4. If it is marked as abandoned, you won't be able to accept license fees/renewals for your version any longer.
  3. I can just use my C4 version for my own needs and not have it in the plugin store.

I'm really fine with any of these. My intent was not to make any additional work for you or take away your revenue from this plugin. I feel like the cleanest way to go is #3, I can just install it for my own needs via composer and move on with life.

@kinoli
Copy link
Owner

kinoli commented Aug 27, 2022

Why dont you just add a pull request for your changes into this repo and it will update in Craft?

@chadcrowell
Copy link
Contributor

Certainly an option, but I hadn't gone that direction because you seemed to indicate you didn't want to deal with the C4 version. Works for me though.

@kinoli
Copy link
Owner

kinoli commented Aug 30, 2022

No, it's fine as long as it doesn't break C3 version.

@robinbeatty
Copy link

I'm someone who's champing at the bit with my wallet open for a C4 version... any options available yet?

@kinoli
Copy link
Owner

kinoli commented Sep 1, 2022

Ok, I'll work on an updated version so it works in Craft 3 and 4. Stay tuned.

@chadcrowell
Copy link
Contributor

I'll setup my pull request today Jesse, hang tight. Save you some time.

@chadcrowell
Copy link
Contributor

Hi Jessie - do you mind creating a tagged release for the C 3/4 version so packages will update and it will be available in C4?

@chadcrowell
Copy link
Contributor

Hi Jessie - do you mind creating a tagged release for the Craft 3/4 version so packagist will update and it will be available in C4? This has just been sitting here since you merged the pull request. Meanwhile, Craft plugin store has no idea it exists for C4.

@jcdarwin
Copy link

If you need to install this package but it hasn't been tagged, you can use an inline alias:

php composer require "kinoli/groupie:dev-master#e7abdf81a185fa614b9d6385dc587fd994f111f3 as 2.0.0"

@iamkeir
Copy link

iamkeir commented Dec 5, 2022

+1 for this being C4 compatible

@iamkeir
Copy link

iamkeir commented Feb 2, 2023

Any update here?

@ThomasDeMarez
Copy link

Seems like Packagist is not synced with the new 2.0.0 release, could you update this on the Packagist side?

Screenshot 2023-04-24 at 10 35 38

In the meantime we are using an inline alias as suggested by @jcdarwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants