Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet item with multiple values #81

Open
simonastoyanova opened this issue Nov 13, 2024 · 1 comment
Open

Facet item with multiple values #81

simonastoyanova opened this issue Nov 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@simonastoyanova
Copy link
Collaborator

simonastoyanova commented Nov 13, 2024

Two cases, one in Execution, one in Place name. Both need splitting but for different reasons.

  1. Multiple values in Execution
    XML: layoutDesc/layout/rs[@ana] where @ana has a dotted value, e.g. '#execution.engraved' which points to the taxonomy file https://github.com/ISicily/ISicily/blob/master/alists/ISicily-taxonomies.xml; when there are two execution values we deliberately keep them in separate rs elements:

Screenshot 2024-11-13 at 16 06 46

In this case the two execution types are complimentary - the text was first engraved and then rubricated.

Example files: http://sicily.classics.ox.ac.uk/inscription/ISic001132, http://sicily.classics.ox.ac.uk/inscription/ISic000107.

  1. Multiple values in Place name
    XML: origPlace/placeName[@type='ancient'] more than once. Rare but happens.

Screenshot 2024-11-13 at 16 24 54

In this case the two places are alternatives, both have @cert='low' as we can't tell which one is more likely.

Example files: http://sicily.classics.ox.ac.uk/inscription/ISic020600

@simonastoyanova simonastoyanova added the enhancement New feature or request label Nov 13, 2024
@geoffroy-noel-ddh geoffroy-noel-ddh added this to the Top 3 priorities milestone Nov 13, 2024
geoffroy-noel-ddh added a commit that referenced this issue Dec 10, 2024
…ultivalued field. Also lowercased to avoid duplicates. gh-81
geoffroy-noel-ddh added a commit that referenced this issue Dec 10, 2024
@geoffroy-noel-ddh
Copy link
Member

The search can now deal properly with multiple values in places of origin and execution types files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants